chrome/content/ui/overlay.xul - Issue 5538776168267776: Implemented anti-adblock message notification

Delta Between Two Patch Sets: chrome/content/ui/overlay.xul

Issue 5538776168267776: Implemented anti-adblock message notification (Closed)

Left Patch Set: Created Feb. 7, 2014, 5:08 p.m.

Right Patch Set: Created Feb. 13, 2014, 12:50 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <?xml version="1.0"?>	1 <?xml version="1.0"?>

2	2

3 <!--	3 <!--

4 - This file is part of Adblock Plus <http://adblockplus.org/>,	4 - This file is part of Adblock Plus <http://adblockplus.org/>,

5 - Copyright (C) 2006-2013 Eyeo GmbH	5 - Copyright (C) 2006-2013 Eyeo GmbH

6 -	6 -

7 - Adblock Plus is free software: you can redistribute it and/or modify	7 - Adblock Plus is free software: you can redistribute it and/or modify

8 - it under the terms of the GNU General Public License version 3 as	8 - it under the terms of the GNU General Public License version 3 as

9 - published by the Free Software Foundation.	9 - published by the Free Software Foundation.

10 -	10 -

(...skipping 106 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
117 </toolbar>	117 </toolbar>

118 </toolbox>	118 </toolbox>

119 <iframe id="abp-bottombar-browser" src="chrome://adblockplus/content/ui/si debar.xul" flex="1"/>	119 <iframe id="abp-bottombar-browser" src="chrome://adblockplus/content/ui/si debar.xul" flex="1"/>

120 </vbox>	120 </vbox>

121 </hbox>	121 </hbox>

122	122

123 <!-- Notification panel -->	123 <!-- Notification panel -->

124 <panel id="abp-notification" type="arrow" orient="vertical"	124 <panel id="abp-notification" type="arrow" orient="vertical"

125 xmlns:html="http://www.w3.org/1999/xhtml">	125 xmlns:html="http://www.w3.org/1999/xhtml">

126 <label id="abp-notification-title" class="header"/>	126 <label id="abp-notification-title" class="header"/>

127 <html:p id="abp-notification-message"/>	127 <html:p id="abp-notification-message"/>
Felix Dahlke 2014/02/11 10:35:27 Didn't we discuss that questions should be shown i Didn't we discuss that questions should be shown in a notification box in Firefox? Note that the notification panel disappears automatically after some time, people can simply ignore it, which we don't want. Thomas Greiner 2014/02/11 16:53:31 Yes, but saying the extent of its constraints (see Show quoted text On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > Didn't we discuss that questions should be shown in a notification box in > Firefox? Note that the notification panel disappears automatically after some > time, people can simply ignore it, which we don't want. Yes, but saying the extent of its constraints (see https://developer.mozilla.org/en/docs/Web/API/notification) it seems like we should stick with the existing panel in Firefox which allows us to add buttons. In ui.js I'm setting the "noautohide" attribute which makes it stay open even after it loses focus. Felix Dahlke 2014/02/11 17:11:12 I meant a notification box, not a desktop notifica Show quoted text On 2014/02/11 16:53:31, Thomas Greiner wrote: > On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > > Didn't we discuss that questions should be shown in a notification box in > > Firefox? Note that the notification panel disappears automatically after some > > time, people can simply ignore it, which we don't want. > > Yes, but saying the extent of its constraints (see > https://developer.mozilla.org/en/docs/Web/API/notification) it seems like we > should stick with the existing panel in Firefox which allows us to add buttons. > > In ui.js I'm setting the "noautohide" attribute which makes it stay open even > after it loses focus. I meant a notification box, not a desktop notification. These things: https://developer.mozilla.org/en-US/docs/XUL/notificationbox?redirectlocale=e... Felix Dahlke 2014/02/11 17:57:17 I could live with doing this in a follow-up though Show quoted text On 2014/02/11 17:11:12, Felix H. Dahlke wrote: > On 2014/02/11 16:53:31, Thomas Greiner wrote: > > On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > > > Didn't we discuss that questions should be shown in a notification box in > > > Firefox? Note that the notification panel disappears automatically after > some > > > time, people can simply ignore it, which we don't want. > > > > Yes, but saying the extent of its constraints (see > > https://developer.mozilla.org/en/docs/Web/API/notification) it seems like we > > should stick with the existing panel in Firefox which allows us to add > buttons. > > > > In ui.js I'm setting the "noautohide" attribute which makes it stay open even > > after it loses focus. > > I meant a notification box, not a desktop notification. These things: > https://developer.mozilla.org/en-US/docs/XUL/notificationbox?redirectlocale=e... I could live with doing this in a follow-up though. This is a big, important change, and we need to have it in the dev builds for a while before it's released. So feel free to leave things as they are for now and create a Trello card for that. Thomas Greiner 2014/02/12 11:58:49 Ok, that's also fine with me. I wouldn't want to d Show quoted text On 2014/02/11 17:57:17, Felix H. Dahlke wrote: > On 2014/02/11 17:11:12, Felix H. Dahlke wrote: > > On 2014/02/11 16:53:31, Thomas Greiner wrote: > > > On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > > > > Didn't we discuss that questions should be shown in a notification box in > > > > Firefox? Note that the notification panel disappears automatically after > > some > > > > time, people can simply ignore it, which we don't want. > > > > > > Yes, but saying the extent of its constraints (see > > > https://developer.mozilla.org/en/docs/Web/API/notification) it seems like we > > > should stick with the existing panel in Firefox which allows us to add > > buttons. > > > > > > In ui.js I'm setting the "noautohide" attribute which makes it stay open > even > > > after it loses focus. > > > > I meant a notification box, not a desktop notification. These things: > > > https://developer.mozilla.org/en-US/docs/XUL/notificationbox?redirectlocale=e... > > I could live with doing this in a follow-up though. This is a big, important > change, and we need to have it in the dev builds for a while before it's > released. So feel free to leave things as they are for now and create a Trello > card for that. Ok, that's also fine with me. I wouldn't want to delay the initial release just because of that but I can work on it right after the release to push it soon after.
128 <hbox id="abp-notification-question">	128 <hbox id="abp-notification-question">

129 <button id="abp-notification-yes" label="&notification.button.yes;" action ="onApproved"/>	129 <button id="abp-notification-yes" label="&notification.button.yes;"/>

130 <button id="abp-notification-no" label="&notification.button.no;" action=" onDeclined"/>	130 <button id="abp-notification-no" label="&notification.button.no;"/>

131 <toolbarbutton id="abp-notification-close">&notification.button.close;</to olbarbutton>	131 <toolbarbutton id="abp-notification-close" label="&notification.button.clo se;"></toolbarbutton>

132 </hbox>	132 </hbox>

133 </panel>	133 </panel>

134 </overlay>	134 </overlay>

LEFT	RIGHT