chrome/locale/en-US/global.properties - Issue 5538776168267776: Implemented anti-adblock message notification

Delta Between Two Patch Sets: chrome/locale/en-US/global.properties

Issue 5538776168267776: Implemented anti-adblock message notification (Closed)

Left Patch Set: Created Feb. 7, 2014, 5:08 p.m.

Right Patch Set: Created Feb. 13, 2014, 12:50 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 default_dialog_title=Adblock Plus	1 default_dialog_title=Adblock Plus

2	2

3 action0_tooltip=Click to bring up context menu, middle-click to enable/disable.	3 action0_tooltip=Click to bring up context menu, middle-click to enable/disable.

4 action1_tooltip=Click to open/close blockable items, middle-click to enable/disa ble.	4 action1_tooltip=Click to open/close blockable items, middle-click to enable/disa ble.

5 action2_tooltip=Click to open preferences, middle-click to enable/disable.	5 action2_tooltip=Click to open preferences, middle-click to enable/disable.

6 action3_tooltip=Click to enable/disable Adblock Plus.	6 action3_tooltip=Click to enable/disable Adblock Plus.

7	7

8 disabled_tooltip=Adblock Plus is disabled.	8 disabled_tooltip=Adblock Plus is disabled.

9 # Note: the placeholder ?1? will be replaced by the number of active filter subs criptions, the placeholder ?2? by the number of custom filters	9 # Note: the placeholder ?1? will be replaced by the number of active filter subs criptions, the placeholder ?2? by the number of custom filters

10 active_tooltip=Adblock Plus is enabled, ?1? filter subscription(s) and ?2? custo m filter(s) in use.	10 active_tooltip=Adblock Plus is enabled, ?1? filter subscription(s) and ?2? custo m filter(s) in use.

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 type_label_media=audio/video	48 type_label_media=audio/video

49 type_label_font=font	49 type_label_font=font

50	50

51 mobile_menu_enable=ABP: Enable	51 mobile_menu_enable=ABP: Enable

52 # Note: the placeholder ?1? will be replaced by the site name. Ideally it should be at the end of the string (space is limited and site names can be long).	52 # Note: the placeholder ?1? will be replaced by the site name. Ideally it should be at the end of the string (space is limited and site names can be long).

53 mobile_menu_enable_site=ABP: Enable on ?1?	53 mobile_menu_enable_site=ABP: Enable on ?1?

54 # Note: the placeholder ?1? will be replaced by the site name. Ideally it should be at the end of the string (space is limited and site names can be long).	54 # Note: the placeholder ?1? will be replaced by the site name. Ideally it should be at the end of the string (space is limited and site names can be long).

55 mobile_menu_disable_site=ABP: Disable on ?1?	55 mobile_menu_disable_site=ABP: Disable on ?1?

56	56

57 notification_antiadblock_title=Hide targeted messages?	57 notification_antiadblock_title=Hide targeted messages?

58 notification_antiadblock_message=This site is known to show targeted messages to Adblock Plus users. Do you want Adblock Plus to hide these everywhere?	58 notification_antiadblock_message=This site has been known to show targeted messa ges to Adblock Plus users. Do you want Adblock Plus to hide targeted messages?
Felix Dahlke 2014/02/11 10:35:27 I suggest some modifications: 1. s/is known/has b I suggest some modifications: 1. s/is known/has been known/ (I think the former isn't really correct here) 2. s/to Adblock Plus users/to users of ad blockers/ (Arguably somewhat controversial. Do we want to point out that there are other ad blockers? But on the other hand, do we want to suggest that the sites are targeting us specifically? Just a suggestion, don't have a strong opinion. Feel free to go with what you prefer here.) 3. s/hide these everywhere/hide targeted messages/ - possibly even "hide targeted messages like these" (I think it makes sense to be very clear here.) Thomas Greiner 2014/02/11 16:53:31 2. I don't think we need to change that. It does s Show quoted text On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > I suggest some modifications: > > 1. s/is known/has been known/ (I think the former isn't really correct here) > 2. s/to Adblock Plus users/to users of ad blockers/ (Arguably somewhat > controversial. Do we want to point out that there are other ad blockers? But on > the other hand, do we want to suggest that the sites are targeting us > specifically? Just a suggestion, don't have a strong opinion. Feel free to go > with what you prefer here.) > 3. s/hide these everywhere/hide targeted messages/ - possibly even "hide > targeted messages like these" (I think it makes sense to be very clear here.) 2. I don't think we need to change that. It does say that the message is shown to ABP users but it doesn't say that it's not showing it to other people as well. Felix Dahlke 2014/02/11 17:11:12 Alright, let's leave it then. Show quoted text On 2014/02/11 16:53:31, Thomas Greiner wrote: > On 2014/02/11 10:35:27, Felix H. Dahlke wrote: > > I suggest some modifications: > > > > 1. s/is known/has been known/ (I think the former isn't really correct here) > > 2. s/to Adblock Plus users/to users of ad blockers/ (Arguably somewhat > > controversial. Do we want to point out that there are other ad blockers? But > on > > the other hand, do we want to suggest that the sites are targeting us > > specifically? Just a suggestion, don't have a strong opinion. Feel free to go > > with what you prefer here.) > > 3. s/hide these everywhere/hide targeted messages/ - possibly even "hide > > targeted messages like these" (I think it makes sense to be very clear here.) > > 2. I don't think we need to change that. It does say that the message is shown > to ABP users but it doesn't say that it's not showing it to other people as > well. Alright, let's leave it then.
LEFT	RIGHT