Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/overlay.xul

Issue 5538776168267776: Implemented anti-adblock message notification (Closed)
Patch Set: Created Feb. 7, 2014, 5:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/locale/en-US/global.properties » ('j') | chrome/locale/en-US/global.properties » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/overlay.xul
===================================================================
--- a/chrome/content/ui/overlay.xul
+++ b/chrome/content/ui/overlay.xul
@@ -124,6 +124,11 @@
<panel id="abp-notification" type="arrow" orient="vertical"
xmlns:html="http://www.w3.org/1999/xhtml">
<label id="abp-notification-title" class="header"/>
- <html:p id="abp-notification-message" maxwidth="300"></html:p>
+ <html:p id="abp-notification-message"/>
Felix Dahlke 2014/02/11 10:35:27 Didn't we discuss that questions should be shown i
Thomas Greiner 2014/02/11 16:53:31 Yes, but saying the extent of its constraints (see
Felix Dahlke 2014/02/11 17:11:12 I meant a notification box, not a desktop notifica
Felix Dahlke 2014/02/11 17:57:17 I could live with doing this in a follow-up though
Thomas Greiner 2014/02/12 11:58:49 Ok, that's also fine with me. I wouldn't want to d
+ <hbox id="abp-notification-question">
+ <button id="abp-notification-yes" label="&notification.button.yes;" action="onApproved"/>
+ <button id="abp-notification-no" label="&notification.button.no;" action="onDeclined"/>
+ <toolbarbutton id="abp-notification-close">&notification.button.close;</toolbarbutton>
+ </hbox>
</panel>
</overlay>
« no previous file with comments | « no previous file | chrome/locale/en-US/global.properties » ('j') | chrome/locale/en-US/global.properties » ('J')

Powered by Google App Engine
This is Rietveld