Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5562887569408000: Issue 1770 - Don't use shadow DOM on docs.google.com, fixing printing there (Closed)

Created:
Jan. 10, 2015, 11:53 a.m. by Sebastian Noack
Modified:
Jan. 13, 2015, 2:22 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1770 - Don't use shadow DOM on docs.google.com, fixing printing there

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrapped long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M include.preload.js View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 10, 2015, 11:55 a.m. (2015-01-10 11:55:16 UTC) #1
Wladimir Palant
I cannot say that I'm happy with this solution but LGTM with the nit fixed. ...
Jan. 13, 2015, 7:30 a.m. (2015-01-13 07:30:27 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5562887569408000/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5562887569408000/diff/5629499534213120/include.preload.js#newcode163 include.preload.js:163: // Also, we can't use shadow DOM on Google ...
Jan. 13, 2015, 12:32 p.m. (2015-01-13 12:32:21 UTC) #3
Wladimir Palant
Jan. 13, 2015, 12:59 p.m. (2015-01-13 12:59:51 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld