Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/JsValue.h

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Left Patch Set: rebase, no changes Created Jan. 22, 2016, 9:26 a.m.
Right Patch Set: rebase Created May 20, 2016, 3:20 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/JsEngine.h ('k') | include/AdblockPlus/Notification.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 117
118 /** 118 /**
119 * Invokes the value as a function (see `IsFunction()`). 119 * Invokes the value as a function (see `IsFunction()`).
120 * @param params Optional list of parameters. 120 * @param params Optional list of parameters.
121 * @param thisPtr Optional `this` value. 121 * @param thisPtr Optional `this` value.
122 * @return Value returned by the function. 122 * @return Value returned by the function.
123 */ 123 */
124 JsValuePtr Call(const JsValueList& params = JsValueList(), 124 JsValuePtr Call(const JsValueList& params = JsValueList(),
125 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const; 125 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
126 126
127 /**
128 * Invokes the value as a function (see `IsFunction()`) with single
129 * parameter.
130 * @param arg A single required parameter.
131 * @return Value returned by the function.
132 */
133 JsValuePtr Call(const JsValue& arg) const;
134
127 v8::Local<v8::Value> UnwrapValue() const; 135 v8::Local<v8::Value> UnwrapValue() const;
128 protected: 136 protected:
129 JsEnginePtr jsEngine; 137 JsEnginePtr jsEngine;
130 private: 138 private:
131 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value); 139 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
132 void SetProperty(const std::string& name, v8::Handle<v8::Value> val); 140 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
133 std::unique_ptr<v8::Persistent<v8::Value>> value; 141 std::unique_ptr<v8::Persistent<v8::Value>> value;
Oleksandr 2016/01/22 12:11:14 Aren't we leaking the value here? The idea behind
134 }; 142 };
135 } 143 }
136 144
137 #endif 145 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld