Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/Notification.h

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Left Patch Set: fix JsValue destructor Created Jan. 22, 2016, 1:16 p.m.
Right Patch Set: rebase Created May 20, 2016, 3:20 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/JsValue.h ('k') | include/AdblockPlus/V8ValueHolder.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 /** 48 /**
49 * Wrapper for an Adblock Plus notification object. 49 * Wrapper for an Adblock Plus notification object.
50 */ 50 */
51 class Notification: public JsValue, 51 class Notification: public JsValue,
52 public std::enable_shared_from_this<Notification> 52 public std::enable_shared_from_this<Notification>
53 { 53 {
54 friend class FilterEngine; 54 friend class FilterEngine;
55 protected: 55 protected:
56 /** 56 /**
57 * Constructor. 57 * Constructor.
58 * @param jsValue `JsValuePtr` notification JavaScript object. 58 * @param jsValue `JsValue&&` notification JavaScript object.
Oleksandr 2016/01/22 14:02:37 The comment is leftover from JsValuePtr days
sergei 2016/01/22 14:34:54 Thanks, fixed
59 */ 59 */
60 explicit Notification(JsValue&& jsValue); 60 explicit Notification(JsValue&& jsValue);
61 public: 61 public:
62 /** 62 /**
63 * Retrieves the type of this notification. 63 * Retrieves the type of this notification.
64 * @return Type of this notification. 64 * @return Type of this notification.
65 */ 65 */
66 NotificationType GetType() const; 66 NotificationType GetType() const;
67 67
68 /** 68 /**
69 * Retrieves the title and message of this notification. 69 * Retrieves the title and message of this notification.
70 * @return Translated texts. 70 * @return Translated texts.
71 */ 71 */
72 NotificationTexts GetTexts(); 72 NotificationTexts GetTexts() const;
73 73
74 /** 74 /**
75 * Retrieves the URLs which should be mapped to the links in the message. 75 * Retrieves the URLs which should be mapped to the links in the message.
76 * @return List of links. 76 * @return List of links.
77 */ 77 */
78 std::vector<std::string> GetLinks() const; 78 std::vector<std::string> GetLinks() const;
79 79
80 /** 80 /**
81 * Marks this notification as shown. It is only relevant for question 81 * Marks this notification as shown. It is only relevant for question
82 * notifications. Other notifications are marked automatically. 82 * notifications. Other notifications are marked automatically.
83 */ 83 */
84 void MarkAsShown(); 84 void MarkAsShown();
85 private: 85 private:
86 }; 86 };
87 typedef std::shared_ptr<Notification> NotificationPtr; 87 typedef std::shared_ptr<Notification> NotificationPtr;
88 } 88 }
89 89
90 #endif 90 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld