Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5634261554036736: Issue 1562 - Improve detecting of XmlHttmlRequest requests (Closed)

Created:
Nov. 13, 2014, 9:11 a.m. by sergei
Modified:
Nov. 21, 2014, 11:13 a.m.
Reviewers:
Oleksandr
CC:
Eric, Felix Dahlke
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add CORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M src/plugin/PluginWbPassThrough.cpp View 1 3 chunks +52 lines, -35 lines 0 comments Download

Messages

Total messages: 5
sergei
Nov. 13, 2014, 9:22 a.m. (2014-11-13 09:22:34 UTC) #1
sergei
added CORS
Nov. 13, 2014, 10:42 a.m. (2014-11-13 10:42:24 UTC) #2
Oleksandr
On 2014/11/13 10:42:24, sergei wrote: > added CORS I think for the time being at ...
Nov. 20, 2014, 11:15 a.m. (2014-11-20 11:15:13 UTC) #3
sergei
On 2014/11/20 11:15:13, Oleksandr wrote: > On 2014/11/13 10:42:24, sergei wrote: > > added CORS ...
Nov. 21, 2014, 10:55 a.m. (2014-11-21 10:55:15 UTC) #4
Oleksandr
Nov. 21, 2014, 11:07 a.m. (2014-11-21 11:07:54 UTC) #5
In that case LGTM without CORS. We can commit that in a separate patch later.

On 2014/11/21 10:55:15, sergei wrote:
> On 2014/11/20 11:15:13, Oleksandr wrote:
> > On 2014/11/13 10:42:24, sergei wrote:
> > > added CORS
> > 
> > I think for the time being at least there is more harm in not classifying
some
> > XMLHttpRequests as XMLHttpRequest, then in classifying some WebGL or
WebFonts
> > requests accidentally as XMLHttpRequest. I'd vote for pushing this.
> 
> I've moved the discussion to issue tracker.

Powered by Google App Engine
This is Rietveld