Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/sidebar.js

Issue 5636077285015552: Issue 656 - Replace some __proto__ with Object.create (Closed)
Patch Set: Created June 23, 2014, 8:46 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/content/ui/sendReport.js ('k') | lib/elemHide.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/sidebar.js
===================================================================
--- a/chrome/content/ui/sidebar.js
+++ b/chrome/content/ui/sidebar.js
@@ -1004,17 +1004,17 @@ var treeView = {
// Custom properties and methods
//
boxObject: null,
atoms: null,
filter: "",
data: null,
allData: [],
- dataMap: {__proto__: null},
+ dataMap: Object.create(null),
sortColumn: null,
sortProc: null,
resortTimeout: null,
itemsDummy: null,
whitelistDummy: null,
itemsDummyTooltip: null,
whitelistDummyTooltip: null,
itemToSelect: null,
@@ -1033,17 +1033,17 @@ var treeView = {
docDomain: createSortWithFallback(compareDocDomain, sortByAddress, false),
docDomainDesc: createSortWithFallback(compareDocDomain, sortByAddress, true),
filterSource: createSortWithFallback(compareFilterSource, sortByAddress, false),
filterSourceDesc: createSortWithFallback(compareFilterSource, sortByAddress, true)
},
clearData: function(data) {
var oldRows = this.rowCount;
this.allData = [];
- this.dataMap = {__proto__: null};
+ this.dataMap = Object.create(null);
this.refilter();
this.boxObject.rowCountChanged(0, -oldRows);
this.boxObject.rowCountChanged(0, this.rowCount);
},
addItem: function(/**Node*/ node, /**RequestEntry*/ item, /**Boolean*/ scanComplete)
{
« no previous file with comments | « chrome/content/ui/sendReport.js ('k') | lib/elemHide.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld