Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content

includes/preftable.tmpl

+{#
+ # This file is part of the Adblock Plus website,
+ # Copyright (C) 2006-2015 Eyeo GmbH
+ #
+ # Adblock Plus is free software: you can redistribute it and/or modify
+ # it under the terms of the GNU General Public License version 3 as
+ # published by the Free Software Foundation.
+ #
+ # Adblock Plus is distributed in the hope that it will be useful,
+ # but WITHOUT ANY WARRANTY; without even the implied warranty of
+ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ # GNU General Public License for more details.
+ #
+ # You should have received a copy of the GNU General Public License
+ # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ #}
+
+{% block body %}
+  <table id="preftable">
+    <tbody>
+      <tr>
+        <th width="30%">{{"prefnamecol"|translate}}</th>
+        <th width="20%">{{"defaultcol"|translate}}</th>
+        <th width="50%">{{"descriptioncol"|translate}}</th>
+      </tr>
+      {% for section in preftable %}
+        <tr id="{{ section.id }}">
+          <td class="section" colspan="3">{{ section.title|translate }}</td>
+        </tr>
+        {% for preference in section.preferences %}
+          <tr id="{{ preference.name }}">
+            <td>
+              <span>extensions.</span>
+              <span>adblockplus.</span>
+              <span class="prefname">{{ preference.name }}</span>
+            </td>
+            {% if preference.default %}
+              <td>{{ preference.default }}</td>
+            {% else %}
+              {% if preference.empty != "false" %}

[kzar, 2015/02/26 19:50:17]

So the logic here around preference.empty seemed broken, I've improved it now so
that the output matches the live site.

I don't think I understand your comment though, looking at the generated
preferences.tmpl I see some preferences with the default of "" and empty of
"false" and some with default of "" with empty of "true".

+                <td>{{ preference.empty }}</td>
+              {% else %}
+                <td>&nbsp</td>
+              {% endif %}
+            {% endif %}
+            <td>{{ preference.description|translate(None, links[preference.description]) }}</td>

[Wladimir Palant, 2015/02/24 20:19:40]

Please allow for multiple description paragraphs, as you did with interfaces.
The fact that I used <br> to separate paragraphs in Anwiki was a hack.

Also, links shouldn't be a separate variable but rather part of the preference:
preference.links rather than links[preference.description].

Nit: Specifying the parameter by name should work better here:

  preference.description|translate(links=preference.links)

[kzar, 2015/02/26 19:50:17]

Done.

+          </tr>
+        {% endfor %}
+      {% endfor %}
+    </tbody>
+  </table>
+{% endblock %}