Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: filters/get_subscriptions.py

Issue 5636796054503424: Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content (Closed)
Patch Set: Addressed a few more comments. Created Feb. 26, 2015, 10:10 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | filters/parse_interface.py » ('j') | includes/preftable.tmpl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # This file is part of the Adblock Plus website,
2 # Copyright (C) 2006-2015 Eyeo GmbH
3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation.
7 #
8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details.
12 #
13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15
16 import codecs
17 import tarfile
18 import urllib
19
20 from sitescripts.subscriptions.subscriptionParser import parse_file, calculate_s upplemented
21
22 def get_subscriptions(_):
Sebastian Noack 2015/02/27 11:10:49 I feel that we begin to misuse template filters. D
Sebastian Noack 2015/02/27 14:42:45 Since Dave apparently doesn't have an opinion here
Wladimir Palant 2015/02/27 15:37:02 Sure, we are misusing the filters mechanism here,
Sebastian Noack 2015/02/27 15:40:43 Sounds good to me.
23 result = {}
24 source = urllib.urlopen("https://hg.adblockplus.org/subscriptionlist/archive/d efault.tar.gz")
Sebastian Noack 2015/02/27 11:10:49 The file-like object returned by urllib.urlopen()
kzar 2015/02/27 14:21:07 Done.
25 with tarfile.open(fileobj=source, mode="r|gz") as archive:
26 for fileinfo in archive:
27 if not fileinfo.name.endswith(".subscription"):
Sebastian Noack 2015/02/27 11:10:49 Nit: os.path.splitext(fileinfo.name)[1] == ".subsc
kzar 2015/02/27 14:21:07 Done.
28 continue
29
30 filedata = parse_file(fileinfo.name, codecs.getreader('utf8')(archive.extr actfile(fileinfo)))
Sebastian Noack 2015/02/27 11:10:49 Nit: Maybe initializing the utf8 reader above the
kzar 2015/02/27 14:21:07 Done.
31 if filedata.unavailable:
32 continue
33
34 result[filedata.name] = filedata
35
36 calculate_supplemented(result)
37 return result.values()
OLDNEW
« no previous file with comments | « no previous file | filters/parse_interface.py » ('j') | includes/preftable.tmpl » ('J')

Powered by Google App Engine
This is Rietveld