filters/subscription_sort.py - Issue 5636796054503424: Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: filters/subscription_sort.py

Issue 5636796054503424: Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content (Closed)

Patch Set: Brought in changes to website made over last few months. Created Jan. 19, 2015, 12:18 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 def subscription_sort(value, prioritizeRecommended=True):
	Sebastian Noack 2015/02/13 17:51:49 Nit: Please use underscores instead camelcase in P Nit: Please use underscores instead camelcase in Python, to comply with PEP-8. kzar 2015/02/20 14:55:18 Done. Show quoted text On 2015/02/13 17:51:49, Sebastian Noack wrote: > Nit: Please use underscores instead camelcase in Python, to comply with PEP-8. Done.
	2 value = value[:] # create a copy of the list

	3 if prioritizeRecommended:

	4 value.sort(lambda a, b: (

	5 cmp(a.get("type"), b.get("type")) or

	6 cmp(a.get("deprecated"), b.get("deprecated")) or

	7 cmp(b.get("catchall"), a.get("catchall")) or

	8 cmp(b.get("recommendation") != None, a.get("recommendation") != None) or
	Sebastian Noack 2015/02/13 17:51:49 None is a singleton. So please always use the "is None is a singleton. So please always use the "is (not)" operator when comparing. Or in case you are just checking whether the key exists, use the "in" operator instead. kzar 2015/02/20 14:55:18 Done. Show quoted text On 2015/02/13 17:51:49, Sebastian Noack wrote: > None is a singleton. So please always use the "is (not)" operator when > comparing. Or in case you are just checking whether the key exists, use the "in" > operator instead. Done.
	9 cmp(a.get("name").lower(), b.get("name").lower())
	Sebastian Noack 2015/02/13 17:51:49 This code will raise an exception anyway if "name" This code will raise an exception anyway if "name" doesn't exist. So using .get() instead canonical item access (square brackets) it pointless here. kzar 2015/02/20 14:55:18 Done. Show quoted text On 2015/02/13 17:51:49, Sebastian Noack wrote: > This code will raise an exception anyway if "name" doesn't exist. So using > .get() instead canonical item access (square brackets) it pointless here. Done.
	10 ))

	11 else:

	12 value.sort(lambda a, b: (

	13 cmp(a.get("type"), b.get("type")) or

	14 cmp(a.get("deprecated"), b.get("deprecated")) or

	15 cmp(a.get("name").lower(), b.get("name").lower())

	16 ))

	17 return value

OLD	NEW

« filters/parse_interface.py ('K') | « filters/parse_interface.py ('k') | filters/unescape.py » ('j') | filters/unescape.py » ('J')