Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content

filters/subscription_sort.py

 # This file is part of the Adblock Plus website,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 def subscription_sort(value, prioritize_recommended=True):
   if prioritize_recommended:
     return sorted(value, lambda a, b: (
-      cmp(getattr(a, "type", None), getattr(b, "type", None)) or

[Wladimir Palant, 2015/02/26 22:01:46]

Why not cmp(a.type, b.type) like in the original function? Same for the other
attributes of course. All these attributes are guaranteed to exist.

[kzar, 2015/02/26 22:12:17]

Done.

-      cmp(getattr(a, "deprecated", None), getattr(b, "deprecated", None)) or
-      cmp(getattr(b, "catchall", None), getattr(a, "catchall", None)) or
-      cmp(getattr(b, "recommendation", None) is not None,
-          getattr(a, "recommendation", None) is not None) or
+      cmp(a.type, b.type) or
+      cmp(a.deprecated, b.deprecated) or
+      cmp(b.catchall, a.catchall) or
+      cmp(b.recommendation is not None, a.recommendation is not None) or
       cmp(a.name.lower(), b.name.lower())
     ))
   else:
     return sorted(value, lambda a, b: (
-      cmp(getattr(a, "type", None), getattr(b, "type", None)) or
-      cmp(getattr(a, "deprecated", None), getattr(b, "deprecated", None)) or
-      cmp(getattr(a, "name", None).lower(), getattr(b, "name", None).lower())
+      cmp(a.type, b.type) or
+      cmp(a.deprecated, b.deprecated) or
+      cmp(a.name.lower(), b.name.lower())
     ))