Left: | ||
Right: |
LEFT | RIGHT |
---|---|
1 def subscription_sort(value, prioritizeRecommended=True): | 1 # This file is part of the Adblock Plus website, |
Sebastian Noack
2015/02/13 17:51:49
Nit: Please use underscores instead camelcase in P
kzar
2015/02/20 14:55:18
Done.
| |
2 value = value[:] # create a copy of the list | 2 # Copyright (C) 2006-2015 Eyeo GmbH |
3 if prioritizeRecommended: | 3 # |
4 value.sort(lambda a, b: ( | 4 # Adblock Plus is free software: you can redistribute it and/or modify |
5 cmp(a.get("type"), b.get("type")) or | 5 # it under the terms of the GNU General Public License version 3 as |
6 cmp(a.get("deprecated"), b.get("deprecated")) or | 6 # published by the Free Software Foundation. |
7 cmp(b.get("catchall"), a.get("catchall")) or | 7 # |
8 cmp(b.get("recommendation") != None, a.get("recommendation") != None) or | 8 # Adblock Plus is distributed in the hope that it will be useful, |
Sebastian Noack
2015/02/13 17:51:49
None is a singleton. So please always use the "is
kzar
2015/02/20 14:55:18
Done.
| |
9 cmp(a.get("name").lower(), b.get("name").lower()) | 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of |
Sebastian Noack
2015/02/13 17:51:49
This code will raise an exception anyway if "name"
kzar
2015/02/20 14:55:18
Done.
| |
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
11 # GNU General Public License for more details. | |
12 # | |
13 # You should have received a copy of the GNU General Public License | |
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. | |
15 | |
16 def subscription_sort(value, prioritize_recommended=True): | |
17 if prioritize_recommended: | |
18 return sorted(value, lambda a, b: ( | |
19 cmp(a.type, b.type) or | |
20 cmp(a.deprecated, b.deprecated) or | |
21 cmp(b.catchall, a.catchall) or | |
22 cmp(b.recommendation is not None, a.recommendation is not None) or | |
23 cmp(a.name.lower(), b.name.lower()) | |
10 )) | 24 )) |
11 else: | 25 else: |
12 value.sort(lambda a, b: ( | 26 return sorted(value, lambda a, b: ( |
13 cmp(a.get("type"), b.get("type")) or | 27 cmp(a.type, b.type) or |
14 cmp(a.get("deprecated"), b.get("deprecated")) or | 28 cmp(a.deprecated, b.deprecated) or |
15 cmp(a.get("name").lower(), b.get("name").lower()) | 29 cmp(a.name.lower(), b.name.lower()) |
16 )) | 30 )) |
17 return value | |
LEFT | RIGHT |