Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content

filters/subscription_sort.py

Index: filters/subscription_sort.py
diff --git a/filters/subscription_sort.py b/filters/subscription_sort.py
new file mode 100644
index 0000000000000000000000000000000000000000..b4ce4aa23b17a263bd50f65f9d84fb5d30cdba21
--- /dev/null
+++ b/filters/subscription_sort.py
@@ -0,0 +1,32 @@
+# This file is part of the Adblock Plus website,
+# Copyright (C) 2006-2015 Eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+
+def subscription_sort(value, prioritize_recommended=True):
+  value = value[:]  # create a copy of the list
+  if prioritize_recommended:
+    value.sort(lambda a, b: (
+        cmp(a.get("type"), b.get("type")) or
+        cmp(a.get("deprecated"), b.get("deprecated")) or
+        cmp(b.get("catchall"), a.get("catchall")) or
+        cmp(b.get("recommendation") is not None, a.get("recommendation") is not None) or
+        cmp(a["name"].lower(), b["name"].lower())
+    ))

[Wladimir Palant, 2015/02/24 20:19:40]

Nit: You can use the global sorted() function, then you won't need to create a
copy of the list:

  return sorted(value, lambda a, b: ...)

And - yes, I know that you simply copied my own code. But I wrote that code
years ago back when I knew very little about Python.

[kzar, 2015/02/26 19:50:17]

Done.

+  else:
+    value.sort(lambda a, b: (
+        cmp(a.get("type"), b.get("type")) or
+        cmp(a.get("deprecated"), b.get("deprecated")) or
+        cmp(a.get("name").lower(), b.get("name").lower())
+    ))
+  return value