Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5637716494516224: Issue 296 - [libadblockplus] Don't require custom build step to eliminate thin archives (Closed)

Created:
April 10, 2014, 1:42 p.m. by Wladimir Palant
Modified:
April 10, 2014, 5:09 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This is quite a hack but it doesn't look like this can be done without touching V8 build configuration. We can use our existing gyp launcher to add our include file.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/v8_gyp_launcher View 1 chunk +2 lines, -0 lines 0 comments Download
A v8.gypi View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 10, 2014, 1:42 p.m. (2014-04-10 13:42:13 UTC) #1
Felix Dahlke
April 10, 2014, 4:33 p.m. (2014-04-10 16:33:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld