Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: devtools-panel.html

Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome (Closed)
Patch Set: Created Jan. 7, 2015, 1:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | devtools-panel.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <html>
Thomas Greiner 2015/01/12 10:37:54 License header and document type are missing
Sebastian Noack 2015/01/12 11:55:07 You are right. I wasn't aware that we add the GPL
Thomas Greiner 2015/01/16 18:17:21 Thank you. Just one more thing: We changed the pro
Sebastian Noack 2015/02/04 14:17:29 Done.
2 <head>
3 <link type="text/css" rel="stylesheet" href="skin/devtools-panel.css">
4 <script type="application/javascript" src="ext/common.js"></script>
Thomas Greiner 2015/01/12 10:37:54 Declaring the type attribute is no longer necessar
Sebastian Noack 2015/01/12 11:55:07 Done.
5 <script type="application/javascript" src="ext/devtools.js"></script>
6 <script type="application/javascript" src="devtools-panel.js"></script>
7 </head>
8 <body>
9 <div id="header">
Thomas Greiner 2015/01/12 10:37:54 What about using <header> here instead?
Thomas Greiner 2015/01/12 10:37:54 The structure is a bit scattered so instead of he
Sebastian Noack 2015/01/12 11:55:07 Done.
Sebastian Noack 2015/01/12 11:55:07 Initially I used that structure. But flexbox requi
Thomas Greiner 2015/01/16 18:17:21 That's a pity and seems like that's also how the D
10 <table>
11 <tr>
12 <td colspan="2">
13 Show
14 <select id="filter-state">
15 <option value="">all</option>
16 <option>blocked</option>
17 <option>whitelisted</option>
18 </select>
19 items of
20 <select id="filter-type">
21 <option value="">any</option>
22 <option>SUBDOCUMENT</option>
23 <option>IMAGE</option>
24 <option>STYLESHEET</option>
25 <option>SCRIPT</option>
26 <option>OBJECT</option>
27 <option>XMLHTTPREQUEST</option>
28 <option>POPUP</option>
29 <option>ELEMHIDE</option>
30 <option>OTHER</option>
Thomas Greiner 2015/01/12 10:37:54 I noticed that we also offer the following content
Sebastian Noack 2015/01/12 11:55:07 We don't have those types on Chrome/Opera/Safari.
31 </select>
32 type
33 </td>
34 </tr>
35 <tr>
36 <td>
37 <div class="request-wrapper">
38 <div class="url">Request</div>
39 <div class="domain">Document domain</div>
40 <div class="type">Type</div>
41 </div>
42 </td>
43 <td>
44 <div class="filter-wrapper">
45 <div class="filter">Filter</div>
46 <div class="origin">Origin</div>
47 </div>
48 </td>
49 </tr>
50 </table>
51 </div>
52 <div id="items">
53 <table></table>
54 </div>
55 <div id="footer">
Thomas Greiner 2015/01/12 10:37:54 Same here with the <footer> tag
Sebastian Noack 2015/01/12 11:55:07 Done.
56 <a id="reload">Reload</a> page to see effect of filter changes
57 </div>
58 </body>
59 </html>
OLDNEW
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | devtools-panel.js » ('J')

Powered by Google App Engine
This is Rietveld