Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5648419829841920: Issue 131 - [Document projects consistently] Add a README.md to the adblockpluschrome repository (Closed)

Created:
Feb. 16, 2015, 10:48 a.m. by Wladimir Palant
Modified:
Feb. 17, 2015, 1:52 p.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 131 - [Document projects consistently] Add a README.md to the adblockpluschrome repository

Patch Set 1 #

Total comments: 13

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A README.md View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
Feb. 16, 2015, 10:48 a.m. (2015-02-16 10:48:49 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md#newcode61 README.md:61: The unit test will run automatically once the page ...
Feb. 16, 2015, 10:52 a.m. (2015-02-16 10:52:34 UTC) #2
kzar
http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md#newcode3 README.md:3: I think usually a brief introduction at the start ...
Feb. 17, 2015, 9:38 a.m. (2015-02-17 09:38:05 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md#newcode10 README.md:10: - [The Jinja2 module](http://jinja.pocoo.org/docs) PIL (Python Imaging Library) is ...
Feb. 17, 2015, 12:07 p.m. (2015-02-17 12:07:56 UTC) #4
Wladimir Palant
I addressed most comments, replied to some. http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5648419829841920/diff/5629499534213120/README.md#newcode23 README.md:23: This will ...
Feb. 17, 2015, 1:19 p.m. (2015-02-17 13:19:21 UTC) #5
Sebastian Noack
LGTM
Feb. 17, 2015, 1:23 p.m. (2015-02-17 13:23:56 UTC) #6
kzar
Feb. 17, 2015, 1:33 p.m. (2015-02-17 13:33:02 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld