Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

include/AdblockPlus/FilterEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 168 matching lines @@
     /**
      * Callback type invoked when the filters change.
      * The first parameter is the action event code (see
      * [FilterNotifier.triggerListeners](https://adblockplus.org/jsdoc/adblockplus/symbols/FilterNotifier.html#.triggerListeners)
      * for the full list).
      * The second parameter is the filter/subscription object affected, if any.
      */
     typedef std::tr1::function<void(const std::string&, const JsValuePtr)> FilterChangeCallback;
 
     /**
-     * Constructor.
+     * Constructor. Allows disabling FRP and auto updates
      * @param jsEngine `JsEngine` instance used to run JavaScript code
      *        internally.
+     * @param disableAutoUpdates `bool` true if automatic updates should
+     *        be disabled
+     * @param disableFRP `bool` true if first run page should be disabled
      */
-    explicit FilterEngine(JsEnginePtr jsEngine);
+    explicit FilterEngine(JsEnginePtr jsEngine, bool firstRunDisabled = false, bool autoUpdatesDisabled = false);

[Eric, 2015/05/15 19:36:13]

Even at this early stage, I think it would be better to pass in an
initialization structure rather than an explicit list of arguments that we're
using at the moment.

A list of name-value pairs would suffice here. The name is a variable name; the
value its initial value. We're already invoking the interpreter to do the
initialization. With hardly more effort we could do initialization here more
generally and more flexibly.

If this were just for the IE version, I don't know that my opinion would be the
same. But we can anticipate that there may be future pre-customization
requirements for Android.

[Felix Dahlke, 2015/05/28 20:42:56]

I agree - in fact, I had something more generic in mind: We could just pass in
an `std::map<std::string, std::string> preconfiguredPrefs` here that holds
default pref values, which can then overwrite the ones read from lib/prefs.js.

That's in line with how preconfiguration works on the other platforms so far,
and it's quite flexible, so I think we should do that.

 
     /**
      * Retrieves the `JsEngine` instance associated with this `FilterEngine`
      * instance.
      */
     JsEnginePtr GetJsEngine() const { return jsEngine; }
 
     /**
      * Checks if this is the first run of the application.
      * @return `true` if the application is running for the first time.
@@ skipping 179 matching lines @@
                                ContentType contentType,
                                const std::string& documentUrl) const;
     void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
     void UpdateCheckDone(const std::string& eventName,
                          UpdateCheckDoneCallback callback, JsValueList& params);
     void FilterChanged(FilterChangeCallback callback, JsValueList& params);
   };
 }
 
 #endif