Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/updater.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 updateUrl = updateUrl.replace(/%NAME%/g, encodeURIComponent(_appInfo.name));
 
 let callback = null;
 
 const INITIAL_DELAY = 0.1 * MILLIS_IN_HOUR;
 const CHECK_INTERVAL = 1 * MILLIS_IN_HOUR;
 const EXPIRATION_INTERVAL = 24 * MILLIS_IN_HOUR;
 const TYPE_AUTOMATIC = 0;
 const TYPE_MANUAL = 1;
 
 let downloader = new Downloader(getDownloadables, INITIAL_DELAY, CHECK_INTERVAL);

[Eric, 2015/05/15 19:36:13]

The actual timer is in the 'Downloader' prototype. To avoid the timer entirely,
avoid instantiating the object 'downloader' as a 'new Downloader'.

Personally, I'd just not instantiate it at all. That would mean including the
next three lines in the condition block (easy) and adding a condition in
'checkForUpdates' below, which is needed anyway.

All the other references to this variable are within handlers below that won't
be called without a 'Downloader' instance activating them.

 downloader.onExpirationChange = onExpirationChange;
 downloader.onDownloadSuccess = onDownloadSuccess;
 downloader.onDownloadError = onDownloadError;
 
 function getDownloadable(forceCheck)

[sergei, 2015/04/21 12:35:24]

In downloader.js there is a function which is called by timer
`_doCheck: function()` which evaluates  the following code `for (let
downloadable of this.dataSource()){...}`. I don't know how it looks after our
transformations but semantically it seems that to disable we should return an
empty array or null or undefined.

 {
   let url = updateUrl.replace(/%TYPE%/g, forceCheck ? TYPE_MANUAL : TYPE_AUTOMATIC);
   let downloadable = new Downloadable(url);
   downloadable.lastError = Prefs.update_last_error;
   downloadable.lastCheck = Prefs.update_last_check;
   downloadable.softExpiration = Prefs.update_soft_expiration;
   downloadable.hardExpiration = Prefs.update_hard_expiration;
   return downloadable;
 }
 
 function getDownloadables()
 {
-  yield getDownloadable(false);
+  yield getDownloadable(!!autoupdatesDisabled);

[sergei, 2015/04/21 12:35:24]

I think we should not touch this line because it influences merely the url.

[Eric, 2015/05/15 19:36:13]

Agreed.

 }
 
 function onExpirationChange(downloadable)
 {
   Prefs.update_last_check = downloadable.lastCheck;
   Prefs.update_soft_expiration = downloadable.softExpiration;
   Prefs.update_hard_expiration = downloadable.hardExpiration;
 }
 
 function onDownloadSuccess(downloadable, responseText, errorCallback, redirectCallback)
@@ skipping 30 matching lines @@
 }
 
 function onDownloadError(downloadable, downloadURL, error, channelStatus, responseStatus, redirectCallback)
 {
   Prefs.update_last_error = Date.now();
   if (callback)
     callback(error);
   callback = null;
 }
 
 let checkForUpdates = exports.checkForUpdates = function checkForUpdates(_callback)

[Eric, 2015/05/15 19:36:13]

We also need to intervene here, since this is where explicit, manual update
checks ultimately arrive.

The correct behavior is likely to immediately call the callback with a suitable
status message.

Aside: It would also be good to disable the menu item in the plugin UI, but I
understand that's rather beyond the scope of the present change set.

 {
   callback = _callback;
   downloader.download(getDownloadable(true));
 }