Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

include/AdblockPlus/FilterEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 168 matching lines @@
     /**
      * Callback type invoked when the filters change.
      * The first parameter is the action event code (see
      * [FilterNotifier.triggerListeners](https://adblockplus.org/jsdoc/adblockplus/symbols/FilterNotifier.html#.triggerListeners)
      * for the full list).
      * The second parameter is the filter/subscription object affected, if any.
      */
     typedef std::tr1::function<void(const std::string&, const JsValuePtr)> FilterChangeCallback;
 
     /**
-     * Constructor.
+     * Constructor. Allows overloading the prefs

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: Kind of redundant with the parameter description, I'd just leave this part
as it is.

      * @param jsEngine `JsEngine` instance used to run JavaScript code
      *        internally.
+     * @param preconfiguredPrefs `std::map<std::string, std::string>` name-value list of preconfigured Prefs

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: 80 columns? We usually manage to stick to that at least in comments :)
Also, Prefs with a lower case "p", plus a period at the end.

      */
-    explicit FilterEngine(JsEnginePtr jsEngine);
+    explicit FilterEngine(JsEnginePtr jsEngine, std::map<std::string, std::string> preconfiguredPrefs = std::map<std::string, std::string>());

[Felix Dahlke, 2015/06/09 19:40:51]

Nit: Put preconfiguredPrefs on its own line? Probably won't fit on 80 columns
either but it's closer that way. We could probably make things short enough by
using a typedef for the map, but that's up to you.

 
     /**
      * Retrieves the `JsEngine` instance associated with this `FilterEngine`
      * instance.
      */
     JsEnginePtr GetJsEngine() const { return jsEngine; }
 
     /**
      * Checks if this is the first run of the application.
      * @return `true` if the application is running for the first time.
@@ skipping 179 matching lines @@
                                ContentType contentType,
                                const std::string& documentUrl) const;
     void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
     void UpdateCheckDone(const std::string& eventName,
                          UpdateCheckDoneCallback callback, JsValueList& params);
     void FilterChanged(FilterChangeCallback callback, JsValueList& params);
   };
 }
 
 #endif