Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/updater.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 18 matching lines @@
 const TYPE_AUTOMATIC = 0;
 const TYPE_MANUAL = 1;
 
 let downloader = new Downloader(getDownloadables, INITIAL_DELAY, CHECK_INTERVAL);
 downloader.onExpirationChange = onExpirationChange;
 downloader.onDownloadSuccess = onDownloadSuccess;
 downloader.onDownloadError = onDownloadError;
 
 function getDownloadable(forceCheck)
 {
+  if (!forceCheck && Preconfig.disable_auto_updates)

[Felix Dahlke, 2015/06/09 19:40:51]

I think we should be using Pref.disable_auto_updates here instead - the object
with preconfigured prefs is only relevant for initialisation, prefs can be
changed later. Applications could change this pref to make automatic updates
configurable, e.g.

+  {
+    return null;
+  }
   let url = updateUrl.replace(/%TYPE%/g, forceCheck ? TYPE_MANUAL : TYPE_AUTOMATIC);
   let downloadable = new Downloadable(url);
   downloadable.lastError = Prefs.update_last_error;
   downloadable.lastCheck = Prefs.update_last_check;
   downloadable.softExpiration = Prefs.update_soft_expiration;
   downloadable.hardExpiration = Prefs.update_hard_expiration;
   return downloadable;
 }
 
 function getDownloadables()
@@ skipping 47 matching lines @@
   if (callback)
     callback(error);
   callback = null;
 }
 
 let checkForUpdates = exports.checkForUpdates = function checkForUpdates(_callback)
 {
   callback = _callback;
   downloader.download(getDownloadable(true));
 }