Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/prefs.js

Issue 5653480979038208: Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates (Closed)
Patch Set: Simplify loading of the defaults Created June 17, 2015, 1:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/prefs.js
===================================================================
--- a/lib/prefs.js
+++ b/lib/prefs.js
@@ -41,10 +41,14 @@
update_hard_expiration: 0,
currentVersion: "0.0",
notificationdata: {},
- notificationurl: "https://notification.adblockplus.org/notification.json"
+ notificationurl: "https://notification.adblockplus.org/notification.json",
+ suppress_first_run_page: false,
+ disable_auto_updates: false
};
-let values = Object.create(defaults);
+let preconfigurable = ["suppress_first_run_page", "disable_auto_updates"];
+
+let values;
let path = _fileSystem.resolve("prefs.json");
let listeners = [];
let isDirty = false;
@@ -131,7 +135,16 @@
},
};
+// Update the default prefs with what was preconfigured
+for (let key in _preconfiguredPrefs)
+ if (preconfigurable.indexOf(key) != -1)
+ defaults[key] = _preconfiguredPrefs[key];
+
+// Define defaults
for (let key in defaults)
defineProperty(key);
+// Set values of prefs based on _preconfiguredPrefs
Felix Dahlke 2015/06/17 18:49:24 Not really, we're setting them based on `defaults`
Oleksandr 2015/06/17 23:53:28 Done.
+values = Object.create(defaults);
+
load();

Powered by Google App Engine
This is Rietveld