Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 5653480979038208: Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates (Closed)
Patch Set: Simplify the setting of global property. Add more tests. Created June 12, 2015, 7:33 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -211,6 +211,13 @@
*/
void SetLogSystem(LogSystemPtr val);
+ /**
+ * Adds a global object that can be accessed by all the scripts.
Felix Dahlke 2015/06/12 08:04:20 Nit: Not necessarily an object, rather "Sets a glo
Oleksandr 2015/06/12 10:47:57 Done.
+ * @param The `std::sting` name of the object to add
Felix Dahlke 2015/06/12 08:04:20 Nit: std::string I guess? Also "name of the proper
Oleksandr 2015/06/12 10:47:57 Done.
+ * @param The `JsValuePtr` value the object to add
Felix Dahlke 2015/06/12 08:04:20 Would be "value of the property to set" then
Oleksandr 2015/06/12 10:47:57 Done.
+ */
+ void SetGlobalProperty(std::string name, AdblockPlus::JsValuePtr value);
+
private:
JsEngine();
@@ -220,6 +227,7 @@
v8::Isolate* isolate;
V8ValueHolder<v8::Context> context;
EventMap eventCallbacks;
+ JsValuePtr globalJsObject;
};
}

Powered by Google App Engine
This is Rietveld