Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 5653480979038208: Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates (Closed)
Patch Set: Simplify the setting of global property. Add more tests. Created June 12, 2015, 7:33 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | include/AdblockPlus/JsEngine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -184,13 +184,17 @@
* The second parameter is the filter/subscription object affected, if any.
*/
typedef std::tr1::function<void(const std::string&, const JsValuePtr)> FilterChangeCallback;
-
+ typedef std::map<std::string, AdblockPlus::JsValuePtr> Prefs;
/**
* Constructor.
* @param jsEngine `JsEngine` instance used to run JavaScript code
* internally.
+ * @param preconfiguredPrefs `std::map<std::string,AdblockPlus::JsValuePtr>`
+ * name-value list of preconfigured prefs.
sergei 2015/06/19 10:07:15 It seems this comment should be for the typedef ab
Oleksandr 2015/06/22 07:47:08 Acknowledged.
*/
- explicit FilterEngine(JsEnginePtr jsEngine);
+ explicit FilterEngine(JsEnginePtr jsEngine,
+ Prefs preconfiguredPrefs = Prefs()
+ );
/**
* Retrieves the `JsEngine` instance associated with this `FilterEngine`
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | include/AdblockPlus/JsEngine.h » ('J')

Powered by Google App Engine
This is Rietveld