Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 5653480979038208: Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates (Closed)
Patch Set: Added a unit test. Changed the global object injection routine. Created June 10, 2015, 8:42 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | include/AdblockPlus/JsEngine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -189,8 +189,13 @@
* Constructor.
* @param jsEngine `JsEngine` instance used to run JavaScript code
* internally.
+ * @param preconfiguredPrefs `std::map<std::string,AdblockPlus::JsValuePtr>`
+ * name-value list of preconfigured prefs.
*/
- explicit FilterEngine(JsEnginePtr jsEngine);
+ explicit FilterEngine(JsEnginePtr jsEngine,
+ std::map<std::string, AdblockPlus::JsValuePtr> preconfiguredPrefs =
+ std::map<std::string, AdblockPlus::JsValuePtr>()
Eric 2015/06/10 17:48:16 It would be useful to add a class-member typedef f
Oleksandr 2015/06/12 10:47:57 Done.
+ );
/**
* Retrieves the `JsEngine` instance associated with this `FilterEngine`
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | include/AdblockPlus/JsEngine.h » ('J')

Powered by Google App Engine
This is Rietveld