Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/updater.js

Index: lib/updater.js
===================================================================
--- a/lib/updater.js
+++ b/lib/updater.js
@@ -36,6 +36,10 @@
 
 function getDownloadable(forceCheck)
 {
+  if (!forceCheck && Pref.disable_auto_updates)

[Eric, 2015/06/10 17:48:16]

This would read more clearly if we were using "enable_auto_updates".

[Felix Dahlke, 2015/06/11 20:21:13]

I've wondered about that too, but IMHO disable makes more sense, since the
default behaviour is to check for updates and this pref is about disabling that,
same as with suppress_first_run_page. Wouldn't mind either way however.

[Oleksandr, 2015/06/12 07:36:14]

This is subjective, of course, but I think enable_auto_updates is better. I'd
live as is, if you don't insist.

+  {
+    return null;
+  }
   let url = updateUrl.replace(/%TYPE%/g, forceCheck ? TYPE_MANUAL : TYPE_AUTOMATIC);
   let downloadable = new Downloadable(url);
   downloadable.lastError = Prefs.update_last_error;