Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5662276015095808: Issue 1540 - Utility method for loading text is at the wrong location (Closed)

Created:
Nov. 6, 2014, 1:06 p.m. by René Jeschke
Modified:
Nov. 24, 2014, 5:09 p.m.
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1540 - Utility method for loading text is at the wrong location

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M src/org/adblockplus/android/AboutDialog.java View 1 chunk +2 lines, -2 lines 0 comments Download
M src/org/adblockplus/android/AdblockPlus.java View 2 chunks +0 lines, -21 lines 0 comments Download
M src/org/adblockplus/android/ProxyConfigurationActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M src/org/adblockplus/android/Utils.java View 2 chunks +30 lines, -0 lines 2 comments Download

Messages

Total messages: 3
René Jeschke
Nov. 6, 2014, 1:40 p.m. (2014-11-06 13:40:53 UTC) #1
Felix Dahlke
LGTM http://codereview.adblockplus.org/5662276015095808/diff/5629499534213120/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5662276015095808/diff/5629499534213120/src/org/adblockplus/android/Utils.java#newcode139 src/org/adblockplus/android/Utils.java:139: text.append('\n'); I wonder why it worked before when ...
Nov. 11, 2014, 9:21 a.m. (2014-11-11 09:21:46 UTC) #2
René Jeschke
Nov. 11, 2014, 11:57 a.m. (2014-11-11 11:57:00 UTC) #3
http://codereview.adblockplus.org/5662276015095808/diff/5629499534213120/src/...
File src/org/adblockplus/android/Utils.java (right):

http://codereview.adblockplus.org/5662276015095808/diff/5629499534213120/src/...
src/org/adblockplus/android/Utils.java:139: text.append('\n');
On 2014/11/11 09:21:46, Felix H. Dahlke wrote:
> I wonder why it worked before when we were cutting off EOL characters. We were
> just using it for HTML, I guess?

Yep, seems like we always only loaded HTML so far, so it didn't matter. It just
felt right to correct this behaviour, though :-)

Powered by Google App Engine
This is Rietveld