Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/BrowserApp.java

Issue 5664054114779136: Issue 2350 - Remove Add-ons, Apps and Sync (Closed)
Patch Set: Removed sync from xml-v11, too Created April 21, 2015, 10:04 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/base/BrowserApp.java
diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java
index 0f562276471f55640e6b6a6ead099d46fd880829..438ab83e76b59f4ff98c39e681daade854b696a5 100644
--- a/mobile/android/base/BrowserApp.java
+++ b/mobile/android/base/BrowserApp.java
@@ -2574,8 +2574,7 @@ public class BrowserApp extends GeckoApp
final boolean inGuestMode = GeckoProfile.get(this).inGuestMode();
share.setVisible(!inGuestMode);
share.setEnabled(StringUtils.isShareableUrl(url) && !inGuestMode);
- MenuUtils.safeSetEnabled(aMenu, R.id.apps, !inGuestMode);
- MenuUtils.safeSetEnabled(aMenu, R.id.addons, !inGuestMode);
+ // Removed R.id.apps and R.id.addons as of issue #2350
Felix Dahlke 2015/04/22 13:29:59 As in that other review - how about s/as of/as par
MenuUtils.safeSetEnabled(aMenu, R.id.downloads, !inGuestMode);
// NOTE: Use MenuUtils.safeSetEnabled because some actions might
@@ -2743,15 +2742,7 @@ public class BrowserApp extends GeckoApp
return true;
}
- if (itemId == R.id.addons) {
- Tabs.getInstance().loadUrlInTab(AboutPages.ADDONS);
- return true;
- }
-
- if (itemId == R.id.apps) {
- Tabs.getInstance().loadUrlInTab(AboutPages.APPS);
- return true;
- }
+ // Removed ADDONS and APPS as of issue #2350
Felix Dahlke 2015/04/22 13:29:59 Tab, not spaces?
if (itemId == R.id.downloads) {
Tabs.getInstance().loadUrlInTab(AboutPages.DOWNLOADS);

Powered by Google App Engine
This is Rietveld