Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5672992042385408: Issue 2503 - Inconsistent behavior: $document flag implied for exception rules with protocol includ… (Closed)

Created:
May 18, 2015, 5:51 p.m. by Wladimir Palant
Modified:
May 19, 2015, 4:22 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2503 - Inconsistent behavior: $document flag implied for exception rules with protocol includ…

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M lib/filterClasses.js View 1 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
May 18, 2015, 5:51 p.m. (2015-05-18 17:51:13 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5672992042385408/diff/5629499534213120/lib/filterClasses.js File lib/filterClasses.js (left): http://codereview.adblockplus.org/5672992042385408/diff/5629499534213120/lib/filterClasses.js#oldcode754 lib/filterClasses.js:754: // ELEMHIDE, POPUP option shouldn't be there by default ...
May 18, 2015, 6:02 p.m. (2015-05-18 18:02:56 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5672992042385408/diff/5629499534213120/lib/filterClasses.js File lib/filterClasses.js (left): http://codereview.adblockplus.org/5672992042385408/diff/5629499534213120/lib/filterClasses.js#oldcode754 lib/filterClasses.js:754: // ELEMHIDE, POPUP option shouldn't be there by default ...
May 18, 2015, 6:06 p.m. (2015-05-18 18:06:29 UTC) #3
Sebastian Noack
May 18, 2015, 6:08 p.m. (2015-05-18 18:08:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld