Issue 5673543668858880: Issue 451 - Fall back to the first known frame instead of hard-coding the top level frame

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5673543668858880: Issue 451 - Fall back to the first known frame instead of hard-coding the top level frame (Closed)

Created:
May 9, 2014, 5:49 p.m. by Sebastian Noack

Modified:
May 15, 2014, 9:39 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

If we encounter an unknown frame on Chrome we fall back to the top level frame. However there are cases where the top level frame is unknown too, for example if it is an extension page, see #451. So we have to fall back to the first known frame, instead hard-coding frames[0].

Patch Set 1 #

Total comments: 1

Created: May 9, 2014, 5:49 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/ext/background.js	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

May 13, 2014, 2:29 p.m. (2014-05-13 14:29:49 UTC) #2

LGTM

http://codereview.adblockplus.org/5673543668858880/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5673543668858880/diff/5629499534213120/chro...
chrome/ext/background.js:316: frame = frames[frameId] ||
frames[Object.keys(frames)[0]];
Object.keys() doesn't guarantee a particular order for the properties. However,
for numerical properties both Safari and Firefox seem to return the properties
in ascending order and associating the request with a random frame won't hurt
much - so I guess changing the code here isn't worth the added complexity.

Expand All Messages | Collapse All Messages