chrome/ext/background.js - Issue 5673543668858880: Issue 451 - Fall back to the first known frame instead of hard-coding the top level frame

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/background.js

Issue 5673543668858880: Issue 451 - Fall back to the first known frame instead of hard-coding the top level frame (Closed)

Patch Set: Created May 9, 2014, 5:49 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/background.js

===================================================================

--- a/chrome/ext/background.js

+++ b/chrome/ext/background.js

@@ -313,7 +313,7 @@

else

frameId = details.frameId;

- frame = frames[frameId] || frames[0];

+ frame = frames[frameId] || frames[Object.keys(frames)[0]];

Wladimir Palant 2014/05/13 14:29:49 Object.keys() doesn't guarantee a particular order

if (frame && !ext.webRequest.onBeforeRequest._dispatch(details.url, details.type, new Page({id: details.tabId}), frame))

return {cancel: true};

« no previous file with comments | « no previous file | no next file » | no next file with comments »