Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5675960980471808: Updated installer with custom action (Closed)

Created:
March 8, 2014, 5:06 a.m. by Eric
Modified:
July 18, 2014, 4:41 p.m.
Visibility:
Public.

Description

Updated installer with custom action

Patch Set 1 #

Total comments: 25
Unified diffs Side-by-side diffs Delta from patch set Stats (+4230 lines, -236 lines) Patch
M installer/installer.gyp View 4 chunks +140 lines, -27 lines 2 comments Download
M installer/src/custom-action/abp_ca.def View 1 chunk +1 line, -1 line 2 comments Download
M installer/src/custom-action/close_application.cpp View 2 chunks +410 lines, -19 lines 11 comments Download
A installer/src/custom-action/close_ie.wxi View 1 chunk +30 lines, -0 lines 0 comments Download
A installer/src/custom-action/close_ie_default.wxl View 1 chunk +12 lines, -0 lines 0 comments Download
A installer/src/custom-action/test/test-close-application.wxs View 1 chunk +827 lines, -0 lines 0 comments Download
A installer/src/installer-lib/custom-i18n.h View 1 chunk +47 lines, -0 lines 0 comments Download
A installer/src/installer-lib/custom-i18n.wxi View 1 chunk +24 lines, -0 lines 0 comments Download
M installer/src/installer-lib/database.h View 3 chunks +146 lines, -17 lines 0 comments Download
M installer/src/installer-lib/database.cpp View 3 chunks +58 lines, -19 lines 0 comments Download
A installer/src/installer-lib/handle.h View 1 chunk +203 lines, -0 lines 0 comments Download
M installer/src/installer-lib/interaction.h View 1 chunk +96 lines, -0 lines 0 comments Download
M installer/src/installer-lib/interaction.cpp View 1 chunk +22 lines, -6 lines 0 comments Download
M installer/src/installer-lib/process.h View 3 chunks +500 lines, -57 lines 0 comments Download
M installer/src/installer-lib/process.cpp View 1 chunk +401 lines, -2 lines 4 comments Download
M installer/src/installer-lib/record.h View 3 chunks +192 lines, -18 lines 0 comments Download
M installer/src/installer-lib/record.cpp View 2 chunks +52 lines, -5 lines 2 comments Download
A installer/src/installer-lib/run-tests.cmd View 1 chunk +7 lines, -0 lines 0 comments Download
M installer/src/installer-lib/session.h View 4 chunks +91 lines, -7 lines 0 comments Download
M installer/src/installer-lib/session.cpp View 1 chunk +77 lines, -28 lines 2 comments Download
A installer/src/installer-lib/test/custom-action-fail.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/database_test.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M installer/src/installer-lib/test/process_test.cpp View 3 chunks +201 lines, -29 lines 0 comments Download
A installer/src/installer-lib/test/property_test.cpp View 1 chunk +39 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib.wxs View 1 chunk +124 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.cpp View 1 chunk +71 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.def View 1 chunk +13 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.rc View 1 chunk +26 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-sandbox.cpp View 1 chunk +139 lines, -0 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 1 chunk +1 line, -1 line 2 comments Download
M installer/src/msi/locale/ar.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/bg-BG.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ca-ES.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/cs-CZ.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/da-DK.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/de.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/el-GR.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/en.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/es-ES.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/et-EE.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/fi-FI.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/fil-PH.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/fr.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/he-IL.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/hi-IN.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/hr-HR.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/hu-HU.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/it.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ja-JP.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/kn-IN.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/mr-IN.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ms.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/nb-NO.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/nl.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/nn-NO.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/pl-PL.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/pt-BR.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/pt-PT.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ro-RO.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ru-RU.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/sk-SK.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/sv-SE.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/th-TH.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/tr-TR.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/uk-UA.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/ur-PK.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/zh-CN.wxl View 1 chunk +5 lines, -0 lines 0 comments Download
M installer/src/msi/locale/zh-TW.wxl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Eric
March 8, 2014, 5:08 a.m. (2014-03-08 05:08:28 UTC) #1
Oleksandr
LGTM in general. Minor remarks and comments. http://codereview.adblockplus.org/5675960980471808/diff/5629499534213120/installer/installer.gyp File installer/installer.gyp (right): http://codereview.adblockplus.org/5675960980471808/diff/5629499534213120/installer/installer.gyp#newcode726 installer/installer.gyp:726: 'src/installer-lib/session.h', We ...
March 12, 2014, 7:26 p.m. (2014-03-12 19:26:03 UTC) #2
Eric
http://codereview.adblockplus.org/5675960980471808/diff/5629499534213120/installer/installer.gyp File installer/installer.gyp (right): http://codereview.adblockplus.org/5675960980471808/diff/5629499534213120/installer/installer.gyp#newcode726 installer/installer.gyp:726: 'src/installer-lib/session.h', On 2014/03/12 19:26:04, Oleksandr wrote: > We don't ...
March 17, 2014, 12:26 p.m. (2014-03-17 12:26:46 UTC) #3
Oleksandr
On 2014/03/17 12:26:46, Eric wrote: > http://codereview.adblockplus.org/5675960980471808/diff/5629499534213120/installer/installer.gyp > File installer/installer.gyp (right): > This can be ...
July 15, 2014, 2:19 p.m. (2014-07-15 14:19:13 UTC) #4
Eric
July 18, 2014, 4:40 p.m. (2014-07-18 16:40:45 UTC) #5
See review for "Whole installer"
http://codereview.adblockplus.org/6202981292703744/

Powered by Google App Engine
This is Rietveld