Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5681038109966336: issue #362 - firefox: block image broken on youtube thumbnails (recommended videos) (Closed)

Created:
Aug. 10, 2014, 11:52 a.m. by saroyanm
Modified:
Aug. 18, 2014, 11:48 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/362

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M lib/requestNotifier.js View 1 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Wladimir can you please have a look on current review, when you have time. I ...
Aug. 10, 2014, 12:24 p.m. (2014-08-10 12:24:49 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5681038109966336/diff/5629499534213120/lib/requestNotifier.js File lib/requestNotifier.js (right): http://codereview.adblockplus.org/5681038109966336/diff/5629499534213120/lib/requestNotifier.js#newcode361 lib/requestNotifier.js:361: setEntry(nodeData, node, this); The the list of blockable items ...
Aug. 14, 2014, 8:44 p.m. (2014-08-14 20:44:57 UTC) #2
saroyanm
New Patch uploaded. http://codereview.adblockplus.org/5681038109966336/diff/5629499534213120/lib/requestNotifier.js File lib/requestNotifier.js (right): http://codereview.adblockplus.org/5681038109966336/diff/5629499534213120/lib/requestNotifier.js#newcode361 lib/requestNotifier.js:361: setEntry(nodeData, node, this); On 2014/08/14 20:44:57, ...
Aug. 17, 2014, 2:25 p.m. (2014-08-17 14:25:20 UTC) #3
Wladimir Palant
Aug. 18, 2014, 11:39 a.m. (2014-08-18 11:39:19 UTC) #4
Nice, LGTM

Powered by Google App Engine
This is Rietveld