Usage of new API, cleanups (reduced)

src/org/adblockplus/brazil/BaseRequestHandler.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.brazil;
 
 import java.util.Properties;
 
 import sunlabs.brazil.server.Handler;
 import sunlabs.brazil.server.Request;
 import sunlabs.brazil.server.Server;
 import sunlabs.brazil.util.http.MimeHeaders;
 
 public abstract class BaseRequestHandler implements Handler
 {
+  public final static String PROXY_HOST = "proxyHost";
+  public final static String PROXY_PORT = "proxyPort";
+  public final static String AUTH = "auth";
 
-  public static final String PROXY_HOST = "proxyHost";
-  public static final String PROXY_PORT = "proxyPort";
-  public static final String AUTH = "auth";
   protected String proxyHost;
   protected int proxyPort = 80;
   protected String auth;
   protected boolean shouldLogHeaders;
-
   protected String prefix;
 
   @Override
-  public boolean init(Server server, String prefix)
+  public boolean init(final Server server, final String prefix)
   {
     this.prefix = prefix;
 
-    Properties props = server.props;
+    final Properties props = server.props;
 
-    proxyHost = props.getProperty(prefix + PROXY_HOST);
+    this.proxyHost = props.getProperty(prefix + PROXY_HOST);
 
-    String s = props.getProperty(prefix + PROXY_PORT);
+    final String s = props.getProperty(prefix + PROXY_PORT);
+
     try
     {
-      proxyPort = Integer.decode(s).intValue();
+      this.proxyPort = Integer.decode(s).intValue();
     }
-    catch (Exception e)
+    catch (final Exception e)
     {
     }
 
-    auth = props.getProperty(prefix + AUTH);
+    this.auth = props.getProperty(prefix + AUTH);
 
-    shouldLogHeaders = (server.props.getProperty(prefix + "proxylog") != null);
+    this.shouldLogHeaders = (server.props.getProperty(prefix + "proxylog") != null);
 
     return true;
   }
 
   /**
    * Dump the headers on stderr
    */
-  public static String dumpHeaders(int count, Request request, MimeHeaders headers, boolean sent)
+  public static String dumpHeaders(final int count, final Request request, final MimeHeaders headers, final boolean sent)
   {
     String prompt;
-    StringBuffer sb = new StringBuffer();
+    final StringBuffer sb = new StringBuffer();
     String label = "   " + count;
     label = label.substring(label.length() - 4);
     if (sent)
     {
       prompt = label + "> ";
       sb.append(prompt).append(request.toString()).append("\n");
     }
     else
     {
       prompt = label + "< ";
     }
 
     for (int i = 0; i < headers.size(); i++)
     {
       sb.append(prompt).append(headers.getKey(i));
       sb.append(": ").append(headers.get(i)).append("\n");
     }
     return (sb.toString());
   }
 }