Usage of new API, cleanups (reduced)

src/org/adblockplus/android/SummarizedPreferences.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
 import android.preference.Preference;
 import android.preference.PreferenceGroup;
 import android.preference.PreferenceScreen;
 
 /**
  * PreferencesActivity which automatically sets preference summaries according
  * to its current values.
  */
 public class SummarizedPreferences extends SherlockPreferenceActivity implements OnSharedPreferenceChangeListener
 {
+  @SuppressWarnings("deprecation")

[Felix Dahlke, 2014/04/28 07:29:01]

As before, not a fan. Also below.

[René Jeschke, 2014/04/28 08:34:32]

Done.

   @Override
   public void onResume()
   {
     super.onResume();
     initSummaries(getPreferenceScreen());
     getPreferenceScreen().getSharedPreferences().registerOnSharedPreferenceChangeListener(this);
   }
 
+  @SuppressWarnings("deprecation")
   @Override
   public void onPause()
   {
     super.onPause();
     getPreferenceScreen().getSharedPreferences().unregisterOnSharedPreferenceChangeListener(this);
   }
 
   @Override
-  public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key)
+  public void onSharedPreferenceChanged(final SharedPreferences sharedPreferences, final String key)
   {
-    Preference pref = findPreference(key);
+    @SuppressWarnings("deprecation")
+    final Preference pref = findPreference(key);
     setPrefSummary(pref);
   }
 
-  protected void setPrefSummary(Preference pref)
+  protected void setPrefSummary(final Preference pref)
   {
     if (pref instanceof ListPreference)
     {
-      CharSequence summary = ((ListPreference) pref).getEntry();
+      final CharSequence summary = ((ListPreference) pref).getEntry();
       if (summary != null)
       {
         pref.setSummary(summary);
       }
     }
     if (pref instanceof EditTextPreference)
     {
-      CharSequence summary = ((EditTextPreference) pref).getText();
+      final CharSequence summary = ((EditTextPreference) pref).getText();
       if (summary != null)
       {
         pref.setSummary(summary);
       }
     }
   }
 
-  protected void initSummaries(PreferenceGroup preference)
+  protected void initSummaries(final PreferenceGroup preference)
   {
     for (int i = preference.getPreferenceCount() - 1; i >= 0; i--)
     {
-      Preference pref = preference.getPreference(i);
+      final Preference pref = preference.getPreference(i);
 
       if (pref instanceof PreferenceGroup || pref instanceof PreferenceScreen)
       {
         initSummaries((PreferenceGroup) pref);
       }
       else
       {
         setPrefSummary(pref);
       }
     }
   }
 
 }