jni/Debug.h - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: jni/Debug.h

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
	(Empty)
1 #ifndef DEBUG

2 #define DEBUG 0

3 #endif

4

5 #ifdef DEBUG

6

7 #include <android/log.h>

8

9 #define D_INFO ANDROID_LOG_INFO

10 #define D_WARN ANDROID_LOG_WARN

11 #define D_ERROR ANDROID_LOG_ERROR

12 #define D(lvl, msg, args...) if(lvl) { __android_log_print(lvl, "JS", msg, ## ar gs ); __android_log_print(lvl, "JS", "\n"); }

13

14 #else

15

16 #define D(lvl, msg, args...)

17

18 #endif

OLD	NEW

« no previous file with comments | « jni/Application.mk ('k') | jni/JniCallbacks.h » ('j') | no next file with comments »