Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: jni/Application.mk
Issue
5697499218051072
:
Usage of new API, cleanups (reduced) (Closed)
Patch Set: Removed even more unrelated changes
Created April 28, 2014, 9:42 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Adressed first batch of review issues.
Patch Set 3: Fixed leftover first-batch review issues.
Patch Set 4: Removed newly added neetutils code
Patch Set 5: Addressed new review issues
Patch Set 6: Removed another whitespace change
Patch Set 7: Removed even more unrelated changes
Patch Set 8: Even more review issues fixed.
Right:
Patch Set 1: None
Patch Set 2: Adressed first batch of review issues.
Patch Set 3: Fixed leftover first-batch review issues.
Patch Set 4: Removed newly added neetutils code
Patch Set 5: Addressed new review issues
Patch Set 6: Removed another whitespace change
Patch Set 7: Removed even more unrelated changes
Patch Set 8: Even more review issues fixed.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
jni/AbpEngine.cpp
jni/Android.mk
jni/AndroidLogSystem.h
jni/AndroidLogSystem.cpp
jni/AndroidWebRequest.h
jni/AndroidWebRequest.cpp
jni/Application.mk
jni/Debug.h
jni/JniCallbacks.h
jni/JniCallbacks.cpp
jni/JniFilterChangeCallback.cpp
jni/JniJsValue.h
jni/JniJsValue.cpp
jni/JniLogSystem.cpp
jni/JniWebRequest.cpp
jni/Utils.h
jni/Utils.cpp
src/com/github/rjeschke/neetutils/Objects.java
src/com/github/rjeschke/neetutils/collections/Tuple.java
src/org/adblockplus/ChunkedOutputStream.java
src/org/adblockplus/android/ABPEngine.java
src/org/adblockplus/android/AboutDialog.java
src/org/adblockplus/android/AdblockPlus.java
src/org/adblockplus/android/AdvancedPreferences.java
src/org/adblockplus/android/AndroidFilterChangeCallback.java
src/org/adblockplus/android/AndroidLogSystem.java
src/org/adblockplus/android/AndroidUpdateAvailableCallback.java
src/org/adblockplus/android/AndroidUpdaterCallback.java
src/org/adblockplus/android/AndroidWebRequest.java
src/org/adblockplus/android/ConfigurationActivity.java
src/org/adblockplus/android/CrashHandler.java
src/org/adblockplus/android/CrashReportDialog.java
src/org/adblockplus/android/HelpfulCheckBoxPreference.java
src/org/adblockplus/android/Preferences.java
src/org/adblockplus/android/ProxyConfigurationActivity.java
src/org/adblockplus/android/ProxyService.java
src/org/adblockplus/android/ProxySettings.java
src/org/adblockplus/android/RefreshableListPreference.java
src/org/adblockplus/android/Starter.java
src/org/adblockplus/android/SubscriptionParser.java
src/org/adblockplus/android/SummarizedPreferences.java
src/org/adblockplus/android/Utils.java
src/org/adblockplus/android/updater/AlarmReceiver.java
src/org/adblockplus/android/updater/UpdaterActivity.java
src/org/adblockplus/android/updater/UpdaterService.java
src/org/adblockplus/brazil/BaseRequestHandler.java
src/org/adblockplus/brazil/RequestHandler.java
src/org/adblockplus/brazil/SSLConnectionHandler.java
src/org/adblockplus/brazil/TransparentProxyHandler.java
src/org/adblockplus/libadblockplus/Filter.java
src/org/adblockplus/libadblockplus/FilterChangeCallback.java
src/org/adblockplus/libadblockplus/HeaderEntry.java
src/org/adblockplus/libadblockplus/JniExceptionHandler.java
src/org/adblockplus/libadblockplus/JsEngine.java
src/org/adblockplus/libadblockplus/JsValue.java
src/org/adblockplus/libadblockplus/ServerResponse.java
src/org/adblockplus/libadblockplus/Subscription.java
src/org/adblockplus/libadblockplus/UpdaterCallback.java
src/org/adblockplus/libadblockplus/WebRequest.java
View unified diff
|
Download patch
« no previous file with comments
|
« jni/AndroidWebRequest.cpp
('k') |
jni/Debug.h »
('j') |
src/org/adblockplus/android/ABPEngine.java »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 APP_STL := gnustl_static
1 APP_STL := gnustl_static
2 APP_CPPFLAGS := -fexceptions
2 APP_CPPFLAGS := -fexceptions
3 APP_ABI := armeabi
3 APP_ABI := armeabi
4
APP_PLATFORM := android-7
4
APP_PLATFORM := android-7
OLD
NEW
« no previous file with comments
|
« jni/AndroidWebRequest.cpp
('k') |
jni/Debug.h »
('j') |
src/org/adblockplus/android/ABPEngine.java »
('J')
Edit Message
Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Created April 11, 2014, 1:31 p.m. by René Jeschke
Modified April 30, 2014, 11:34 a.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 93
This is Rietveld