Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/org/adblockplus/android/AboutDialog.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Fixed leftover first-batch review issues. Created April 16, 2014, 5:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 13 matching lines...) Expand all
24 import android.os.Bundle; 24 import android.os.Bundle;
25 import android.text.Html; 25 import android.text.Html;
26 import android.text.method.LinkMovementMethod; 26 import android.text.method.LinkMovementMethod;
27 import android.view.Window; 27 import android.view.Window;
28 import android.widget.TextView; 28 import android.widget.TextView;
29 29
30 public class AboutDialog extends Dialog 30 public class AboutDialog extends Dialog
31 { 31 {
32 private static Context context = null; 32 private static Context context = null;
33 33
34 public AboutDialog(Context context) 34 public AboutDialog(final Context context)
35 { 35 {
36 super(context); 36 super(context);
37 AboutDialog.context = context; 37 AboutDialog.context = context;
38 } 38 }
39 39
40 @Override 40 @Override
41 public void onCreate(Bundle savedInstanceState) 41 public void onCreate(final Bundle savedInstanceState)
42 { 42 {
43 requestWindowFeature(Window.FEATURE_NO_TITLE); 43 requestWindowFeature(Window.FEATURE_NO_TITLE);
44 setContentView(R.layout.about); 44 setContentView(R.layout.about);
45 45
46 // Get package version code and name 46 // Get package version code and name
47 String versionName = "--"; 47 String versionName = "--";
48 int versionCode = -1; 48 int versionCode = -1;
49 try 49 try
50 { 50 {
51 PackageInfo pi = context.getPackageManager().getPackageInfo(context.getPac kageName(), 0); 51 final PackageInfo pi = context.getPackageManager().getPackageInfo(context. getPackageName(), 0);
52 versionName = pi.versionName; 52 versionName = pi.versionName;
53 versionCode = pi.versionCode; 53 versionCode = pi.versionCode;
54 } 54 }
55 catch (NameNotFoundException ex) 55 catch (final NameNotFoundException ex)
56 { 56 {
57 // ignore - it can not happen because we query information about ourselves 57 // ignore - it can not happen because we query information about ourselves
58 } 58 }
59 59
60 // Construct html 60 // Construct html
61 StringBuilder info = new StringBuilder(); 61 final StringBuilder info = new StringBuilder();
62 info.append("<h3>"); 62 info.append("<h3>");
63 info.append(context.getString(R.string.app_name)); 63 info.append(context.getString(R.string.app_name));
64 info.append("</h3>"); 64 info.append("</h3>");
65 info.append("<p>"); 65 info.append("<p>");
66 info.append(context.getString(R.string.version)); 66 info.append(context.getString(R.string.version));
67 info.append(": "); 67 info.append(": ");
68 info.append(versionName); 68 info.append(versionName);
69 info.append(" "); 69 info.append(" ");
70 info.append(context.getString(R.string.build)); 70 info.append(context.getString(R.string.build));
71 info.append(" "); 71 info.append(" ");
72 info.append(versionCode); 72 info.append(versionCode);
73 info.append("</p>"); 73 info.append("</p>");
74 AdblockPlus.appendRawTextFile(context, info, R.raw.info); 74 AdblockPlus.appendRawTextFile(context, info, R.raw.info);
75 AdblockPlus.appendRawTextFile(context, info, R.raw.legal); 75 AdblockPlus.appendRawTextFile(context, info, R.raw.legal);
76 76
77 // Show text 77 // Show text
78 TextView tv = (TextView) findViewById(R.id.about_text); 78 final TextView tv = (TextView) findViewById(R.id.about_text);
79 tv.setText(Html.fromHtml(info.toString())); 79 tv.setText(Html.fromHtml(info.toString()));
80 tv.setMovementMethod(LinkMovementMethod.getInstance()); 80 tv.setMovementMethod(LinkMovementMethod.getInstance());
81 } 81 }
82 } 82 }
OLDNEW
« no previous file with comments | « src/org/adblockplus/android/ABPEngine.java ('k') | src/org/adblockplus/android/AdblockPlus.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld