Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/org/adblockplus/android/CrashReportDialog.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Left Patch Set: Addressed new review issues Created April 28, 2014, 8:34 a.m.
Right Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/org/adblockplus/android/CrashHandler.java ('k') | src/org/adblockplus/android/HelpfulCheckBoxPreference.java » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 29 matching lines...) Expand all
40 import android.view.Window; 40 import android.view.Window;
41 import android.widget.EditText; 41 import android.widget.EditText;
42 import android.widget.Toast; 42 import android.widget.Toast;
43 43
44 /** 44 /**
45 * Shows crash report dialog asking user to submit crash report together with co mments. 45 * Shows crash report dialog asking user to submit crash report together with co mments.
46 */ 46 */
47 public final class CrashReportDialog extends Activity 47 public final class CrashReportDialog extends Activity
48 { 48 {
49 private static final String TAG = Utils.getTag(CrashReportDialog.class); 49 private static final String TAG = Utils.getTag(CrashReportDialog.class);
50
51 private String report; 50 private String report;
52 51
53 @Override 52 @Override
54 protected void onCreate(final Bundle savedInstanceState) 53 protected void onCreate(final Bundle savedInstanceState)
55 { 54 {
56 super.onCreate(savedInstanceState); 55 super.onCreate(savedInstanceState);
57 requestWindowFeature(Window.FEATURE_LEFT_ICON); 56 requestWindowFeature(Window.FEATURE_LEFT_ICON);
58 setContentView(R.layout.crashreport); 57 setContentView(R.layout.crashreport);
59 58
60 final Bundle extras = getIntent().getExtras(); 59 final Bundle extras = getIntent().getExtras();
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 } 168 }
170 finish(); 169 finish();
171 } 170 }
172 171
173 public void onCancel(final View v) 172 public void onCancel(final View v)
174 { 173 {
175 deleteFile(CrashHandler.REPORT_FILE); 174 deleteFile(CrashHandler.REPORT_FILE);
176 finish(); 175 finish();
177 } 176 }
178 } 177 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld