jni/JniCallbacks.cpp - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: jni/JniCallbacks.cpp

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: jni/JniCallbacks.cpp

diff --git a/jni/JniCallbacks.cpp b/jni/JniCallbacks.cpp

index 92097fd623df7a027cac6af300bc14ff7696fe6a..b0da62d6c86528571875fbc0c86515f9a7ec1f77 100644

--- a/jni/JniCallbacks.cpp

+++ b/jni/JniCallbacks.cpp

@@ -18,10 +18,10 @@

#include "JniCallbacks.h"

JniCallbackBase::JniCallbackBase(JNIEnv* env, jobject callbackObject)

+ : callbackObject(new JniGlobalReference<jobject>(env, callbackObject)),

+ exceptionLoggerClass(new JniGlobalReference<jclass>(env, env->FindClass(PKG("JniExceptionHandler"))))

{

env->GetJavaVM(&javaVM);

- this->callbackObject.reset(new JniGlobalReference<jobject>(env, callbackObject));

- exceptionLoggerClass.reset(new JniGlobalReference<jclass>(env, env->FindClass(PKG("JniExceptionHandler"))));

}

JniCallbackBase::~JniCallbackBase()

« no previous file with comments | « jni/JniCallbacks.h ('k') | jni/JniFilterChangeCallback.cpp » ('j') | no next file with comments »