Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/libadblockplus/JniExceptionHandler.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/org/adblockplus/libadblockplus/JniExceptionHandler.java
diff --git a/src/org/adblockplus/libadblockplus/JniExceptionHandler.java b/src/org/adblockplus/libadblockplus/JniExceptionHandler.java
index e147a146a2e24dc35824aba7c8c1ccee4e6a079a..6a7fbbf20a9666c2ea0d1741e6ba76942ae688a9 100644
--- a/src/org/adblockplus/libadblockplus/JniExceptionHandler.java
+++ b/src/org/adblockplus/libadblockplus/JniExceptionHandler.java
@@ -19,8 +19,14 @@ package org.adblockplus.libadblockplus;
import java.util.concurrent.LinkedBlockingQueue;
+import org.adblockplus.android.Utils;
+
+import android.util.Log;
+
public final class JniExceptionHandler
{
+ private final static String TAG = Utils.getTag(JniExceptionHandler.class);
+
private static LogWorker logWorker = null;
static
@@ -53,8 +59,7 @@ public final class JniExceptionHandler
try
{
final Throwable t = this.exceptionQueue.take();
- // TODO: We need a log callback
- System.err.println("EXCEPTION: " + t);
+ Log.e(TAG, "Exception from JNI", t);
}
catch (final InterruptedException ie)
{
« no previous file with comments | « src/org/adblockplus/libadblockplus/HeaderEntry.java ('k') | src/org/adblockplus/libadblockplus/JsEngine.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld