Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/ConfigurationActivity.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Even more review issues fixed. Created April 28, 2014, 10:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/org/adblockplus/android/AndroidWebRequest.java ('k') | src/org/adblockplus/android/CrashHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/ConfigurationActivity.java
diff --git a/src/org/adblockplus/android/ConfigurationActivity.java b/src/org/adblockplus/android/ConfigurationActivity.java
index 0a516e16113561305b474b473c238dfef026c484..2a847ab058349c98d8846aa007d906072d0a6d5a 100644
--- a/src/org/adblockplus/android/ConfigurationActivity.java
+++ b/src/org/adblockplus/android/ConfigurationActivity.java
@@ -33,31 +33,31 @@ public class ConfigurationActivity extends Activity
private int port;
@Override
- public void onCreate(Bundle savedInstanceState)
+ public void onCreate(final Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);
setContentView(R.layout.configuration);
port = getIntent().getIntExtra("port", 0);
- String msg1 = getString(R.string.msg_notraffic);
- String msg2 = getString(R.string.msg_configuration);
+ final String msg1 = getString(R.string.msg_notraffic);
+ final String msg2 = getString(R.string.msg_configuration);
((TextView) findViewById(R.id.message_text)).setText(Html.fromHtml(msg1 + " " + msg2));
}
- public void onOk(View view)
+ public void onOk(final View view)
{
finish();
}
- public void onHelp(View view)
+ public void onHelp(final View view)
{
- Intent intent;
+ final Intent intent;
if (ProxyService.NATIVE_PROXY_SUPPORTED)
{
intent = new Intent(this, ProxyConfigurationActivity.class).putExtra("port", port);
}
else
{
- Uri uri = Uri.parse(getString(R.string.configuring_proxy_url));
+ final Uri uri = Uri.parse(getString(R.string.configuring_proxy_url));
intent = new Intent(Intent.ACTION_VIEW, uri);
}
startActivity(intent);
« no previous file with comments | « src/org/adblockplus/android/AndroidWebRequest.java ('k') | src/org/adblockplus/android/CrashHandler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld