src/org/adblockplus/libadblockplus/JsEngine.java - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/org/adblockplus/libadblockplus/JsEngine.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Adressed first batch of review issues. Created April 16, 2014, 5:36 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/org/adblockplus/libadblockplus/JsEngine.java

diff --git a/src/org/adblockplus/libadblockplus/JsEngine.java b/src/org/adblockplus/libadblockplus/JsEngine.java

index af806880cb0872faae1c0f92cb296b6840816243..e3e1056fd81885e9a0e4c1fe49b81a571f94829a 100644

--- a/src/org/adblockplus/libadblockplus/JsEngine.java

+++ b/src/org/adblockplus/libadblockplus/JsEngine.java

@@ -22,7 +22,7 @@ import java.util.List;

import com.github.rjeschke.neetutils.dispose.Disposable;

import com.github.rjeschke.neetutils.dispose.Disposer;

-public class JsEngine implements Disposable

+public final class JsEngine implements Disposable

{

private final Disposer disposer;

protected final long ptr;