src/org/adblockplus/libadblockplus/FilterChangeCallback.java - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/org/adblockplus/libadblockplus/FilterChangeCallback.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Adressed first batch of review issues. Created April 16, 2014, 5:36 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/org/adblockplus/libadblockplus/FilterChangeCallback.java

diff --git a/src/org/adblockplus/libadblockplus/FilterChangeCallback.java b/src/org/adblockplus/libadblockplus/FilterChangeCallback.java

index ea2e4494250f992055104459b9216080b3327ae0..8a818df10a028877228050a555ce27f2f0a8cf41 100644

--- a/src/org/adblockplus/libadblockplus/FilterChangeCallback.java

+++ b/src/org/adblockplus/libadblockplus/FilterChangeCallback.java

@@ -37,7 +37,7 @@ public abstract class FilterChangeCallback implements Disposable

this.disposer = new Disposer(this, new DisposeWrapper(this.ptr));

}

- public abstract void filterChangeCallback(String arg, JsValue jsValue);

+ public abstract void filterChangeCallback(String action, JsValue jsValue);

@Override

public void dispose()