Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/ProxyConfigurationActivity.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Addressed new review issues Created April 28, 2014, 8:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/org/adblockplus/android/Preferences.java ('k') | src/org/adblockplus/android/ProxyService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/ProxyConfigurationActivity.java
diff --git a/src/org/adblockplus/android/ProxyConfigurationActivity.java b/src/org/adblockplus/android/ProxyConfigurationActivity.java
index 0105c17617e5908779808228ae56264f99426267..cf138f173a75cd16475f21c6a94379b98b6fb897 100644
--- a/src/org/adblockplus/android/ProxyConfigurationActivity.java
+++ b/src/org/adblockplus/android/ProxyConfigurationActivity.java
@@ -13,31 +13,31 @@ import android.widget.TextView;
public class ProxyConfigurationActivity extends Activity
{
@Override
- public void onCreate(Bundle savedInstanceState)
+ public void onCreate(final Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);
setContentView(R.layout.proxyconfiguration);
- int port = getIntent().getIntExtra("port", 0);
+ final int port = getIntent().getIntExtra("port", 0);
- StringBuilder info = new StringBuilder();
- int textId = ProxyService.NATIVE_PROXY_SUPPORTED ? R.raw.proxysettings : R.raw.proxysettings_old;
+ final StringBuilder info = new StringBuilder();
+ final int textId = ProxyService.NATIVE_PROXY_SUPPORTED ? R.raw.proxysettings : R.raw.proxysettings_old;
AdblockPlus.appendRawTextFile(this, info, textId);
- String msg = String.format(info.toString(), port);
+ final String msg = String.format(info.toString(), port);
- TextView tv = (TextView) findViewById(R.id.message_text);
+ final TextView tv = (TextView) findViewById(R.id.message_text);
tv.setText(Html.fromHtml(msg));
tv.setMovementMethod(LinkMovementMethod.getInstance());
- Button buttonToHide = (Button) findViewById(ProxyService.NATIVE_PROXY_SUPPORTED ? R.id.gotit : R.id.opensettings);
+ final Button buttonToHide = (Button) findViewById(ProxyService.NATIVE_PROXY_SUPPORTED ? R.id.gotit : R.id.opensettings);
buttonToHide.setVisibility(View.GONE);
}
- public void onGotit(View view)
+ public void onGotit(final View view)
{
finish();
}
- public void onSettings(View view)
+ public void onSettings(final View view)
{
startActivity(new Intent(Settings.ACTION_WIFI_SETTINGS));
finish();
« no previous file with comments | « src/org/adblockplus/android/Preferences.java ('k') | src/org/adblockplus/android/ProxyService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld