Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/HelpfulCheckBoxPreference.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Addressed new review issues Created April 28, 2014, 8:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/org/adblockplus/android/CrashReportDialog.java ('k') | src/org/adblockplus/android/Preferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/HelpfulCheckBoxPreference.java
diff --git a/src/org/adblockplus/android/HelpfulCheckBoxPreference.java b/src/org/adblockplus/android/HelpfulCheckBoxPreference.java
index 32bf02023f0806cc9894889c2009c4c98e1baaad..7c3f0af66d240aa2b158fd34bb163f5f14bf66f0 100644
--- a/src/org/adblockplus/android/HelpfulCheckBoxPreference.java
+++ b/src/org/adblockplus/android/HelpfulCheckBoxPreference.java
@@ -35,13 +35,13 @@ public class HelpfulCheckBoxPreference extends CheckBoxPreference
private OnClickListener helpClickListener;
private String url;
- public HelpfulCheckBoxPreference(Context context, AttributeSet attrs)
+ public HelpfulCheckBoxPreference(final Context context, final AttributeSet attrs)
{
super(context, attrs);
}
@Override
- protected void onBindView(View view)
+ protected void onBindView(final View view)
{
super.onBindView(view);
@@ -62,7 +62,7 @@ public class HelpfulCheckBoxPreference extends CheckBoxPreference
helpImage.setOnClickListener(new OnClickListener()
{
@Override
- public void onClick(View v)
+ public void onClick(final View v)
{
if (helpClickListener != null)
{
@@ -70,20 +70,20 @@ public class HelpfulCheckBoxPreference extends CheckBoxPreference
}
else if (url != null)
{
- Uri uri = Uri.parse(url);
- Intent intent = new Intent(Intent.ACTION_VIEW, uri);
+ final Uri uri = Uri.parse(url);
+ final Intent intent = new Intent(Intent.ACTION_VIEW, uri);
HelpfulCheckBoxPreference.this.getContext().startActivity(intent);
}
}
});
}
- public void setOnHelpClickListener(OnClickListener l)
+ public void setOnHelpClickListener(final OnClickListener l)
{
helpClickListener = l;
}
- public void setHelpUrl(String url)
+ public void setHelpUrl(final String url)
{
this.url = url;
}
« no previous file with comments | « src/org/adblockplus/android/CrashReportDialog.java ('k') | src/org/adblockplus/android/Preferences.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld