Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/SubscriptionParser.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Addressed new review issues Created April 28, 2014, 8:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/org/adblockplus/android/Starter.java ('k') | src/org/adblockplus/android/SummarizedPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/SubscriptionParser.java
diff --git a/src/org/adblockplus/android/SubscriptionParser.java b/src/org/adblockplus/android/SubscriptionParser.java
index 945d190503df39a97ede4d21267944ce908df702..05f664fc4d191039403105b029fe7146aced9a2a 100755
--- a/src/org/adblockplus/android/SubscriptionParser.java
+++ b/src/org/adblockplus/android/SubscriptionParser.java
@@ -33,17 +33,17 @@ class SubscriptionParser extends DefaultHandler
private static final String PREFIXES = "prefixes";
private static final String AUTHOR = "author";
- private List<Subscription> subscriptions;
+ private final List<Subscription> subscriptions;
private Subscription currentSubscription;
- public SubscriptionParser(List<Subscription> subscriptions)
+ public SubscriptionParser(final List<Subscription> subscriptions)
{
super();
this.subscriptions = subscriptions;
}
@Override
- public void startElement(String uri, String localName, String qName, Attributes attributes) throws SAXException
+ public void startElement(final String uri, final String localName, final String qName, final Attributes attributes) throws SAXException
{
if (localName.equalsIgnoreCase(SUBSCRIPTION))
{
@@ -52,10 +52,10 @@ class SubscriptionParser extends DefaultHandler
currentSubscription.specialization = attributes.getValue(SPECIALIZATION);
currentSubscription.url = attributes.getValue(URL);
currentSubscription.homepage = attributes.getValue(HOMEPAGE);
- String prefix = attributes.getValue(PREFIXES);
+ final String prefix = attributes.getValue(PREFIXES);
if (prefix != null)
{
- String[] prefixes = prefix.split(",");
+ final String[] prefixes = prefix.split(",");
currentSubscription.prefixes = prefixes;
}
currentSubscription.author = attributes.getValue(AUTHOR);
@@ -64,7 +64,7 @@ class SubscriptionParser extends DefaultHandler
}
@Override
- public void endElement(String uri, String localName, String qName) throws SAXException
+ public void endElement(final String uri, final String localName, final String qName) throws SAXException
{
if (localName.equalsIgnoreCase(SUBSCRIPTION))
{
« no previous file with comments | « src/org/adblockplus/android/Starter.java ('k') | src/org/adblockplus/android/SummarizedPreferences.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld