Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/android/AboutDialog.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Addressed new review issues Created April 28, 2014, 8:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/org/adblockplus/android/ABPEngine.java ('k') | src/org/adblockplus/android/AdblockPlus.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/org/adblockplus/android/AboutDialog.java
diff --git a/src/org/adblockplus/android/AboutDialog.java b/src/org/adblockplus/android/AboutDialog.java
index 2a0219b274cfcd0eb74beb84387c15606d1ae405..1dbadeeb3c13f080cd7920ea63b093d3b4886c1e 100644
--- a/src/org/adblockplus/android/AboutDialog.java
+++ b/src/org/adblockplus/android/AboutDialog.java
@@ -31,14 +31,14 @@ public class AboutDialog extends Dialog
{
private static Context context = null;
- public AboutDialog(Context context)
+ public AboutDialog(final Context context)
{
super(context);
AboutDialog.context = context;
}
@Override
- public void onCreate(Bundle savedInstanceState)
+ public void onCreate(final Bundle savedInstanceState)
{
requestWindowFeature(Window.FEATURE_NO_TITLE);
setContentView(R.layout.about);
@@ -48,17 +48,17 @@ public class AboutDialog extends Dialog
int versionCode = -1;
try
{
- PackageInfo pi = context.getPackageManager().getPackageInfo(context.getPackageName(), 0);
+ final PackageInfo pi = context.getPackageManager().getPackageInfo(context.getPackageName(), 0);
versionName = pi.versionName;
versionCode = pi.versionCode;
}
- catch (NameNotFoundException ex)
+ catch (final NameNotFoundException ex)
{
// ignore - it can not happen because we query information about ourselves
}
// Construct html
- StringBuilder info = new StringBuilder();
+ final StringBuilder info = new StringBuilder();
info.append("<h3>");
info.append(context.getString(R.string.app_name));
info.append("</h3>");
@@ -75,7 +75,7 @@ public class AboutDialog extends Dialog
AdblockPlus.appendRawTextFile(context, info, R.raw.legal);
// Show text
- TextView tv = (TextView) findViewById(R.id.about_text);
+ final TextView tv = (TextView) findViewById(R.id.about_text);
tv.setText(Html.fromHtml(info.toString()));
tv.setMovementMethod(LinkMovementMethod.getInstance());
}
« no previous file with comments | « src/org/adblockplus/android/ABPEngine.java ('k') | src/org/adblockplus/android/AdblockPlus.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld