Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/org/adblockplus/brazil/SSLConnectionHandler.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)
Patch Set: Fixed leftover first-batch review issues. Created April 16, 2014, 5:51 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/org/adblockplus/brazil/SSLConnectionHandler.java
diff --git a/src/org/adblockplus/brazil/SSLConnectionHandler.java b/src/org/adblockplus/brazil/SSLConnectionHandler.java
index e6324be3609dd72a165e23a4ddbaba1b2288a1d6..9ec131dc4d49f04ba13268a8176d15c1cfb6dfc0 100644
--- a/src/org/adblockplus/brazil/SSLConnectionHandler.java
+++ b/src/org/adblockplus/brazil/SSLConnectionHandler.java
@@ -30,15 +30,13 @@ import sunlabs.brazil.util.MatchString;
/**
* <code>RequestHandler</code> implements a SSL tunnel.
*
- * The following configuration parameters are used to initialize this
- * <code>Handler</code>:
+ * The following configuration parameters are used to initialize this <code>Handler</code>:
* <dl class=props>
*
* <dt>prefix, suffix, glob, match
* <dd>Specify the URL that triggers this handler. (See {@link MatchString}).
* <dt>auth
- * <dd>The value of the proxy-authenticate header (if any) sent to the upstream
- * proxy
+ * <dd>The value of the proxy-authenticate header (if any) sent to the upstream proxy
* <dt>proxyHost
* <dd>If specified, the name of the upstream proxy
* <dt>proxyPort
@@ -46,8 +44,7 @@ import sunlabs.brazil.util.MatchString;
*
* </dl>
*
- * A sample set of configuration parameters illustrating how to use this
- * handler follows:
+ * A sample set of configuration parameters illustrating how to use this handler follows:
*
* <pre>
* handler=https
@@ -56,14 +53,14 @@ import sunlabs.brazil.util.MatchString;
*
* See the description under {@link sunlabs.brazil.server.Handler#respond
* respond} for a more detailed explanation.
- *
+ *j
* Original source by Jochen Luell, PAW (http://paw-project.sourceforge.net/)
*/
public class SSLConnectionHandler extends BaseRequestHandler
{
@Override
- public boolean respond(Request request) throws IOException
+ public boolean respond(final Request request) throws IOException
{
if (!request.method.equals("CONNECT"))
return false;
@@ -87,7 +84,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
}
else
{
- int c = request.url.indexOf(':');
+ final int c = request.url.indexOf(':');
host = request.url.substring(0, c);
port = Integer.parseInt(request.url.substring(c + 1));
}
@@ -97,7 +94,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
serverSocket.setKeepAlive(true);
serverSocket.connect(new InetSocketAddress(host, port));
}
- catch (Exception e)
+ catch (final Exception e)
{
request.sendError(500, "SSL connection failure");
return true;
@@ -108,7 +105,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
if (proxyHost != null)
{
// Forward request to upstream proxy
- OutputStream out = serverSocket.getOutputStream();
+ final OutputStream out = serverSocket.getOutputStream();
out.write((request.method + " " + request.url + " " + request.protocol + "\r\n").getBytes());
request.headers.print(out);
out.write("\r\n".getBytes());
@@ -117,14 +114,14 @@ public class SSLConnectionHandler extends BaseRequestHandler
else
{
// Send response to client
- OutputStream out = request.sock.getOutputStream();
+ final OutputStream out = request.sock.getOutputStream();
out.write((request.protocol + " 200 Connection established\r\n\r\n").getBytes());
out.flush();
}
// Start bi-directional data transfer
- ConnectionHandler client = new ConnectionHandler(request.sock, serverSocket);
- ConnectionHandler server = new ConnectionHandler(serverSocket, request.sock);
+ final ConnectionHandler client = new ConnectionHandler(request.sock, serverSocket);
+ final ConnectionHandler server = new ConnectionHandler(serverSocket, request.sock);
client.start();
server.start();
@@ -132,7 +129,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
client.join();
server.join();
}
- catch (InterruptedException e)
+ catch (final InterruptedException e)
{
request.log(Server.LOG_ERROR, prefix, "Data exchange error: " + e.getMessage());
}
@@ -146,10 +143,10 @@ public class SSLConnectionHandler extends BaseRequestHandler
private class ConnectionHandler extends Thread
{
- private InputStream in;
- private OutputStream out;
+ private final InputStream in;
+ private final OutputStream out;
- ConnectionHandler(Socket sin, Socket sout) throws IOException
+ ConnectionHandler(final Socket sin, final Socket sout) throws IOException
{
in = sin.getInputStream();
out = sout.getOutputStream();
@@ -158,7 +155,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
@Override
public void run()
{
- byte[] buf = new byte[4096];
+ final byte[] buf = new byte[4096];
int count;
try
@@ -169,7 +166,7 @@ public class SSLConnectionHandler extends BaseRequestHandler
}
out.flush();
}
- catch (IOException e)
+ catch (final IOException e)
{
e.printStackTrace();
}
« no previous file with comments | « src/org/adblockplus/brazil/RequestHandler.java ('k') | src/org/adblockplus/brazil/TransparentProxyHandler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld