Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5702288324689920: Make sure that translations used in manifest.json exist in all languages (Closed)

Created:
March 13, 2014, 3:12 p.m. by Sebastian Noack
Modified:
March 13, 2014, 4:56 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/53

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Patch Set 3 : Fixed malformed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M packagerChrome.py View 1 2 4 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
LGTM but I would prefer the nit below to be addressed nevertheless. http://codereview.adblockplus.org/5702288324689920/diff/5629499534213120/packagerChrome.py File packagerChrome.py ...
March 13, 2014, 3:21 p.m. (2014-03-13 15:21:44 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5702288324689920/diff/5629499534213120/packagerChrome.py File packagerChrome.py (right): http://codereview.adblockplus.org/5702288324689920/diff/5629499534213120/packagerChrome.py#newcode292 packagerChrome.py:292: defaults.append((name, info)) On 2014/03/13 15:21:45, Wladimir Palant wrote: > ...
March 13, 2014, 3:44 p.m. (2014-03-13 15:44:33 UTC) #2
Wladimir Palant
March 13, 2014, 4:56 p.m. (2014-03-13 16:56:29 UTC) #3
Even more LGTM

Powered by Google App Engine
This is Rietveld